-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade instrumentation_library_metrics
to scope_metrics
#1507
Upgrade instrumentation_library_metrics
to scope_metrics
#1507
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1507 +/- ##
==========================================
+ Coverage 84.61% 84.63% +0.02%
==========================================
Files 155 155
Lines 4782 4781 -1
==========================================
Hits 4046 4046
+ Misses 736 735 -1
|
Thanks for the PR. Looks good in general. One suggestion - do you think we should introduce |
Agree, do you think if we can rename |
Yes, that's a good idea. I was actually thinking to keep both, but your suggestion seems better, as cleanup would be easy. |
1e83f0f
to
2e6ad6f
Compare
Done |
exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_recordable.h
Outdated
Show resolved
Hide resolved
exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_recordable.h
Show resolved
Hide resolved
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_log_recordable.h
Outdated
Show resolved
Hide resolved
exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_recordable.h
Outdated
Show resolved
Hide resolved
648269b
to
e94545f
Compare
exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_recordable.h
Outdated
Show resolved
Hide resolved
e94545f
to
6d2bacc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once all the comments are resolved.
This looks good to merge, but being bigger PR, we can wait for @esigo or @ThomsonTan to review it. |
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @owent for the PR :)
@owent - Need to rebase this to merge :) |
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
6d2bacc
to
45bc9ea
Compare
Thanks and done. |
Signed-off-by: owentou <[email protected]>
…lemetry#1507) * Upgrade `instrumentation_library_metrics` to `scope_metrics` Signed-off-by: owentou <[email protected]> * Rename `InstrumentationLibrary` -> `InstrumentationScope` Signed-off-by: owentou <[email protected]> * Fix style Signed-off-by: owentou <[email protected]> * Fix compiling Signed-off-by: owentou <[email protected]> * Remove duplicated `ElasticSearchRecordable::SetInstrumentationLibrary` Signed-off-by: owentou <[email protected]> * Fix comments Signed-off-by: owentou <[email protected]> * Update the usage of `instrumentation_library` of prometheus exporter. Signed-off-by: owentou <[email protected]>
…lemetry#1507) * Upgrade `instrumentation_library_metrics` to `scope_metrics` Signed-off-by: owentou <[email protected]> * Rename `InstrumentationLibrary` -> `InstrumentationScope` Signed-off-by: owentou <[email protected]> * Fix style Signed-off-by: owentou <[email protected]> * Fix compiling Signed-off-by: owentou <[email protected]> * Remove duplicated `ElasticSearchRecordable::SetInstrumentationLibrary` Signed-off-by: owentou <[email protected]> * Fix comments Signed-off-by: owentou <[email protected]> * Update the usage of `instrumentation_library` of prometheus exporter. Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou [email protected]
Fixes #1492
Fixed #1506
Changes
instrumentation_info_metric_data_
inResourceMetrics
andinstrumentation_info_metrics
inMetricCollector::Collect
PopulateResourceMetrics
toscope_metrics
in OTLP exportersInstrumentationInfoMetrics
toScopeMetrics
instrumentation_library_
toscope_
instrumentation_metrics
toscope_metrics
InstrumentationLibrary
toInstrumentationScope
GetInstrumentationLibrary
toGetInstrumentationScope
SetInstrumentationLibrary
toSetInstrumentationScope
printInstrumentationLibrary
toprintInstrumentationScope
instrumentation_library_
toinstrumentation_scope_
instrumentation_library
toinstrumentation_library
GetInstrumentationLibrary
andSetInstrumentationLibrary
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes