Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to build nlohmann-json only it's depended. #1505

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

owent
Copy link
Member

@owent owent commented Jul 20, 2022

Signed-off-by: owentou [email protected]

Fixes #1502

Changes

Try to build nlohmann-json only it's depended.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team July 20, 2022 03:15
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #1505 (bd84ddf) into main (abf3312) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1505   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         156      156           
  Lines        4784     4784           
=======================================
  Hits         4050     4050           
  Misses        734      734           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix :)

@esigo esigo merged commit beba414 into open-telemetry:main Jul 20, 2022
@owent owent deleted the build_nlohmann_json_only_when_need branch July 22, 2022 06:11
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTLP Exporter] OTLP gRPC exporter cmake build shouldn't depend on nlohmann-json
3 participants