Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple async callbacks #1495

Merged
merged 32 commits into from
Aug 5, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into multi-callback-approach
lalitb authored Aug 1, 2022

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
commit d52451c44df0443d5569a682ca21e340fdacc01b
2 changes: 0 additions & 2 deletions sdk/include/opentelemetry/sdk/metrics/meter.h
Original file line number Diff line number Diff line change
@@ -114,10 +114,8 @@ class Meter final : public opentelemetry::metrics::Meter
std::shared_ptr<sdk::metrics::MeterContext> meter_context_;
// Mapping between instrument-name and Aggregation Storage.
std::unordered_map<std::string, std::shared_ptr<MetricStorage>> storage_registry_;

std::unique_ptr<SyncWritableMetricStorage> RegisterSyncMetricStorage(
InstrumentDescriptor &instrument_descriptor);

std::unique_ptr<AsyncWritableMetricStorage> RegisterAsyncMetricStorage(
InstrumentDescriptor &instrument_descriptor);
};
1 change: 0 additions & 1 deletion sdk/test/metrics/async_metric_storage_test.cc
Original file line number Diff line number Diff line change
@@ -96,7 +96,6 @@ TEST_P(WritableMetricStorageTestFixture, TestAggregation)
collectors.push_back(collector);
size_t count_attributes = 0;

MeasurementFetcher measurement_fetcher;
opentelemetry::sdk::metrics::AsyncMetricStorage storage(instr_desc, AggregationType::kSum,
new DefaultAttributesProcessor());
long get_count = 20l;
You are viewing a condensed version of this merge commit. You can view the full changes here.