Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install sdk-config.h #1419

Merged
merged 3 commits into from
Jun 9, 2022
Merged

install sdk-config.h #1419

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15e3d9f
install sdk-config.h
flier Jun 1, 2022
eca54eb
Merge branch 'main' into fix-install-sdk-config
lalitb Jun 6, 2022
6a2a923
Merge branch 'main' into fix-install-sdk-config
flier Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ install(
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})

install(
DIRECTORY include/opentelemetry
DIRECTORY include/opentelemetry/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why adding a trailing / fixes the issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing '/' ensures to copy the contents of source /include/opentelemetry/* directory, and not the /include/opentelemetry directory itself to destination.

DESTINATION include/opentelemetry
FILES_MATCHING
PATTERN "*config.h")
Expand Down