Otlp gRPC log example #1083
Merged
Otlp gRPC log example #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…telemetry-cpp into otlp-grpc-log-example
Codecov Report
@@ Coverage Diff @@
## main #1083 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 158 158
Lines 6077 6077
=======================================
Hits 5737 5737
Misses 340 340 |
lalitb
approved these changes
Nov 22, 2021
ThomsonTan
reviewed
Nov 22, 2021
examples/otlp/README.md
Outdated
| @@ -7,6 +7,7 @@ Protocol](https://github.com/open-telemetry/opentelemetry-specification/blob/mai | |||
| The application in `grpc_main.cc` initializes an `OtlpGrpcExporter` instance, | |||
| the application in `http_main.cc` initializes an `OtlpHttpExporter` instance. | |||
| The application in `http_log_main.cc` initializes an `OtlpHttpLogExporter` instance | |||
| The application in `grpc_log_main.cc` initializes an `OtlpGrpcLogExporter` instance | |||
There was a problem hiding this comment.
nit: fix period in line 9 and 10, or fix the whole sentence from line 7 to 10.
ThomsonTan
approved these changes
Nov 23, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otlp gRPC log example
Changes
Adds otlp gRPC log example
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes