Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: regex is neither working on GCC 4.9.x #1069

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

hcoona
Copy link
Contributor

@hcoona hcoona commented Nov 16, 2021

Fixes #1066

@hcoona hcoona requested a review from a team November 16, 2021 06:06
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1069 (4228d6f) into main (69fdf67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files         158      158           
  Lines        6077     6077           
=======================================
  Hits         5737     5737           
  Misses        340      340           
Impacted Files Coverage Δ
api/include/opentelemetry/trace/trace_state.h 97.60% <ø> (ø)

@ThomsonTan ThomsonTan merged commit 3db551f into open-telemetry:main Nov 16, 2021
@hcoona hcoona deleted the private/hcoona/fix-gcc492 branch November 16, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The document say gcc 4.8 is supported but failed to run with gcc 4.9.2
3 participants