Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: span_id should not break strict aliasing. #1068

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Improvement: span_id should not break strict aliasing. #1068

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b9daa8
Improvement: span_id should not break strict aliasing.
hcoona Nov 16, 2021
78695b8
Merge branch 'main' into private/hcoona/fix-strict-aliasing
ThomsonTan Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/include/opentelemetry/trace/span_id.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ class SpanId final
// Returns false if the SpanId is all zeros.
bool IsValid() const noexcept
{
static_assert(kSize == 8, "update is needed if kSize is not 8");
return *reinterpret_cast<const uint64_t *>(&rep_) != 0ull;
static constexpr uint8_t kEmptyRep[kSize] = {0};
return memcmp(rep_, kEmptyRep, kSize) != 0;
}

// Copies the opaque SpanId data to dest.
Expand Down