Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build opentelemetry-proto collector interface with cmake only if WITH_OTLP_GRPC is enabled. #1061

Merged
merged 4 commits into from
Nov 13, 2021
Merged

Build opentelemetry-proto collector interface with cmake only if WITH_OTLP_GRPC is enabled. #1061

merged 4 commits into from
Nov 13, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 12, 2021 •
edited
Loading

Fixes #1035

Changes

  • Build opentelemetry-proto collector service with cmake only if WITH_OTLP_GRPC is enabled.
  • Build example/grpc only if WITH_OTLP_GRPC is enabled.
  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team November 12, 2021 04:16
@lalitb lalitb changed the title Build opentelemetry-proto collector service for cmake only if WITH_PROTO_GRPC is enabled. Build opentelemetry-proto collector interface for cmake only if WITH_PROTO_GRPC is enabled. Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021 •
edited
Loading

Codecov Report

Merging #1061 (2658e50) into main (e21f033) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files         158      158           
  Lines        6077     6077           
=======================================
  Hits         5737     5737           
  Misses        340      340

@lalitb lalitb changed the title Build opentelemetry-proto collector interface for cmake only if WITH_PROTO_GRPC is enabled. Build opentelemetry-proto collector interface with cmake only if WITH_PROTO_GRPC is enabled. Nov 12, 2021
@lalitb lalitb changed the title Build opentelemetry-proto collector interface with cmake only if WITH_PROTO_GRPC is enabled. Build opentelemetry-proto collector interface with cmake only if WITH_OTLP_GRPC is enabled. Nov 12, 2021
@lalitb lalitb mentioned this pull request Nov 12, 2021
Closed
3 tasks
@lalitb
Copy link
Member Author

lalitb commented Nov 13, 2021

/easycla

@lalitb lalitb merged commit eca856d into open-telemetry:main Nov 13, 2021
esigo pushed a commit to esigo/opentelemetry-cpp that referenced this pull request Nov 16, 2021
@lalitb @esigo
Build opentelemetry-proto collector interface with cmake only if WITH…
c11771b 
…_OTLP_GRPC is enabled. (open-telemetry#1061)
@lalitb lalitb mentioned this pull request Dec 1, 2021
Closed
@owent owent mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmake error
2 participants
@lalitb @ThomsonTan