-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus Exporter #1031
Merged
Merged
Add Prometheus Exporter #1031
Changes from all commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
38f811a
Add PrometheusExporter header, source, and test files
erichsueh3 140efcd
CI formatting, added copyright headers
erichsueh3 feb7126
Added build files
erichsueh3 5d6fc7e
modified comments to reflect removal of ReturnCodes class, removal of…
erichsueh3 845d6f1
Merge branch 'master' into prom_exporter
erichsueh3 32880b0
minor change to structure of friend class
erichsueh3 61783a7
Merge branch 'prom_exporter' of https://github.com/erichsueh3/opentel…
erichsueh3 b8d8f5a
Merge branch 'master' into prom_exporter
erichsueh3 94af70d
removed assignment of exposer_ to nullptr in testing constructor
erichsueh3 550bb7f
Merge branch 'master' into prom_exporter
erichsueh3 367d6a3
removed usage of release9.0 of Prometheus
erichsueh3 a5e2cfb
BUILD file changes
erichsueh3 6bbb051
changed Prometheus client back to 9.0
erichsueh3 d3d44f3
removed a test for debugging
erichsueh3 8dc5cb1
Revert "removed a test for debugging"
erichsueh3 94f78c8
format
erichsueh3 5938aa8
added MAKE_EXE_LINKER_FLAGS cmake link option
erichsueh3 dc28f84
added -D to flag
erichsueh3 75e23e5
changed -DMAKE_EXE_LINKER_FLAGS to -DCMAKE_EXE_LINKER_FLAGS
erichsueh3 f9a4dda
Add PrometheusExporter header, source, and test files
erichsueh3 0a5fb81
CI formatting, added copyright headers
erichsueh3 2251d49
Added build files
erichsueh3 81d1c1c
modified comments to reflect removal of ReturnCodes class, removal of…
erichsueh3 b85f648
minor change to structure of friend class
erichsueh3 2f480c0
removed assignment of exposer_ to nullptr in testing constructor
erichsueh3 99ca914
removed usage of release9.0 of Prometheus
erichsueh3 605e42f
BUILD file changes
erichsueh3 87e4223
changed Prometheus client back to 9.0
erichsueh3 c83723d
removed a test for debugging
erichsueh3 4ef1e90
Revert "removed a test for debugging"
erichsueh3 9e8dcdb
format
erichsueh3 ba7bb88
added MAKE_EXE_LINKER_FLAGS cmake link option
erichsueh3 8267094
added -D to flag
erichsueh3 81db277
changed -DMAKE_EXE_LINKER_FLAGS to -DCMAKE_EXE_LINKER_FLAGS
erichsueh3 e3ad09c
Merge branch 'prom_exporter' of https://github.com/erichsueh3/opentel…
esigo 99572e0
Add PrometheusExporter header, source, and test files
erichsueh3 a22933e
CI formatting, added copyright headers
erichsueh3 5055c68
Added build files
erichsueh3 5023d44
modified comments to reflect removal of ReturnCodes class, removal of…
erichsueh3 347caa6
minor change to structure of friend class
erichsueh3 8e7abd3
removed assignment of exposer_ to nullptr in testing constructor
erichsueh3 0195f4b
removed usage of release9.0 of Prometheus
erichsueh3 1cb72fe
BUILD file changes
erichsueh3 8a463b2
changed Prometheus client back to 9.0
erichsueh3 d1fc9d4
removed a test for debugging
erichsueh3 673f1bb
Revert "removed a test for debugging"
erichsueh3 825373f
format
erichsueh3 b4df355
added MAKE_EXE_LINKER_FLAGS cmake link option
erichsueh3 f96756e
added -D to flag
erichsueh3 9fccc94
changed -DMAKE_EXE_LINKER_FLAGS to -DCMAKE_EXE_LINKER_FLAGS
erichsueh3 d7d7010
Add PrometheusExporter header, source, and test files
erichsueh3 9085479
CI formatting, added copyright headers
erichsueh3 e0c974a
Added build files
erichsueh3 f1aadef
modified comments to reflect removal of ReturnCodes class, removal of…
erichsueh3 b33edf9
minor change to structure of friend class
erichsueh3 69de0e8
removed assignment of exposer_ to nullptr in testing constructor
erichsueh3 fd32df6
removed usage of release9.0 of Prometheus
erichsueh3 f7da657
BUILD file changes
erichsueh3 2986e8c
changed Prometheus client back to 9.0
erichsueh3 bc872ed
removed a test for debugging
erichsueh3 1859eca
Revert "removed a test for debugging"
erichsueh3 80c811b
format
erichsueh3 398256d
added MAKE_EXE_LINKER_FLAGS cmake link option
erichsueh3 3d424d2
added -D to flag
erichsueh3 5e3b456
changed -DMAKE_EXE_LINKER_FLAGS to -DCMAKE_EXE_LINKER_FLAGS
erichsueh3 f54b772
Merge branch 'esigo-prometheus-exporter' of https://github.com/esigo/…
esigo 6ca2e10
fix compile fail
esigo 032bfb9
fix cmake and format
esigo 4d4f0ef
bazel format
esigo ef20e67
use prometheus subdir
esigo 908e19d
prometheus install handled in cmake
esigo f6f5c8b
update CHANGELOG
esigo 4648358
Merge branch 'main' into esigo-prometheus-exporter
esigo 5f2744a
Merge branch 'main' into esigo-prometheus-exporter
lalitb bdd2a7b
comments
esigo ba8e877
Merge branch 'main' into esigo-prometheus-exporter
esigo 5052fd5
fix ci
esigo abc06b7
remove debug message
esigo d1c226e
fix bazel ci and comments
esigo a6f3315
fix cmake ci
esigo 6c0e4d3
comments
esigo c93caf7
install missing targets
esigo 8ff4d7a
Merge branch 'main' into esigo-prometheus-exporter
lalitb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
exporters/prometheus/include/opentelemetry/exporters/prometheus/prometheus_exporter.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
#pragma once | ||
#ifdef ENABLE_METRICS_PREVIEW | ||
# include <memory> | ||
# include <string> | ||
# include <vector> | ||
|
||
# include "opentelemetry/exporters/prometheus/prometheus_collector.h" | ||
# include "opentelemetry/sdk/_metrics/exporter.h" | ||
# include "opentelemetry/sdk/_metrics/record.h" | ||
# include "opentelemetry/version.h" | ||
# include "prometheus/exposer.h" | ||
|
||
/** | ||
* This class is an implementation of the MetricsExporter interface and | ||
* exports Prometheus metrics data. Functions in this class should be | ||
* called by the Controller in our data pipeline. | ||
*/ | ||
|
||
OPENTELEMETRY_BEGIN_NAMESPACE | ||
|
||
namespace exporter | ||
{ | ||
namespace prometheus | ||
{ | ||
class PrometheusExporter : public sdk::metrics::MetricsExporter | ||
{ | ||
public: | ||
/** | ||
* Constructor - binds an exposer and collector to the exporter | ||
* @param address: an address for an exposer that exposes | ||
* an HTTP endpoint for the exporter to connect to | ||
*/ | ||
PrometheusExporter(std::string &address); | ||
|
||
/** | ||
* Exports a batch of Metric Records. | ||
* @param records: a collection of records to export | ||
* @return: returns a ReturnCode detailing a success, or type of failure | ||
*/ | ||
sdk::common::ExportResult Export( | ||
const std::vector<sdk::metrics::Record> &records) noexcept override; | ||
|
||
/** | ||
* Shuts down the exporter and does cleanup. | ||
* Since Prometheus is a pull based interface, | ||
* we cannot serve data remaining in the intermediate | ||
* collection to to client an HTTP request being sent, | ||
* so we flush the data. | ||
*/ | ||
void Shutdown() noexcept; | ||
|
||
/** | ||
* @return: returns a shared_ptr to | ||
* the PrometheusCollector instance | ||
*/ | ||
std::shared_ptr<PrometheusCollector> &GetCollector(); | ||
|
||
/** | ||
* @return: Gets the shutdown status of the exporter | ||
*/ | ||
bool IsShutdown() const; | ||
|
||
private: | ||
/** | ||
* exporter shutdown status | ||
*/ | ||
bool is_shutdown_; | ||
|
||
/** | ||
* Pointer to a | ||
* PrometheusCollector instance | ||
*/ | ||
std::shared_ptr<PrometheusCollector> collector_; | ||
|
||
/** | ||
* Pointer to an | ||
* Exposer instance | ||
*/ | ||
std::unique_ptr<::prometheus::Exposer> exposer_; | ||
|
||
/** | ||
* friend class for testing | ||
*/ | ||
friend class PrometheusExporterTest; | ||
|
||
/** | ||
* PrometheusExporter constructor with no parameters | ||
* Used for testing only | ||
*/ | ||
PrometheusExporter(); | ||
}; | ||
} // namespace prometheus | ||
} // namespace exporter | ||
OPENTELEMETRY_END_NAMESPACE | ||
#endif // ENABLE_METRICS_PREVIEW |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#ifdef ENABLE_METRICS_PREVIEW | ||
# include "opentelemetry/exporters/prometheus/prometheus_exporter.h" | ||
|
||
OPENTELEMETRY_BEGIN_NAMESPACE | ||
|
||
namespace exporter | ||
{ | ||
namespace prometheus | ||
{ | ||
/** | ||
* Constructor - binds an exposer and collector to the exporter | ||
* @param address: an address for an exposer that exposes | ||
* an HTTP endpoint for the exporter to connect to | ||
*/ | ||
PrometheusExporter::PrometheusExporter(std::string &address) : is_shutdown_(false) | ||
{ | ||
exposer_ = std::unique_ptr<::prometheus::Exposer>(new ::prometheus::Exposer{address}); | ||
collector_ = std::shared_ptr<PrometheusCollector>(new PrometheusCollector); | ||
|
||
exposer_->RegisterCollectable(collector_); | ||
} | ||
|
||
/** | ||
* PrometheusExporter constructor with no parameters | ||
* Used for testing only | ||
*/ | ||
PrometheusExporter::PrometheusExporter() : is_shutdown_(false) | ||
{ | ||
collector_ = std::unique_ptr<PrometheusCollector>(new PrometheusCollector); | ||
} | ||
|
||
/** | ||
* Exports a batch of Metric Records. | ||
* @param records: a collection of records to export | ||
* @return: returns a ReturnCode detailing a success, or type of failure | ||
*/ | ||
sdk::common::ExportResult PrometheusExporter::Export( | ||
const std::vector<sdk::metrics::Record> &records) noexcept | ||
{ | ||
if (is_shutdown_) | ||
{ | ||
return sdk::common::ExportResult::kFailure; | ||
} | ||
else if (records.empty()) | ||
{ | ||
return sdk::common::ExportResult::kFailureInvalidArgument; | ||
} | ||
else if (collector_->GetCollection().size() + records.size() > | ||
(size_t)collector_->GetMaxCollectionSize()) | ||
{ | ||
return sdk::common::ExportResult::kFailureFull; | ||
} | ||
else | ||
{ | ||
collector_->AddMetricData(records); | ||
return sdk::common::ExportResult::kSuccess; | ||
} | ||
} | ||
|
||
/** | ||
* Shuts down the exporter and does cleanup. | ||
* Since Prometheus is a pull based interface, | ||
* we cannot serve data remaining in the intermediate | ||
* collection to to client an HTTP request being sent, | ||
* so we flush the data. | ||
*/ | ||
void PrometheusExporter::Shutdown() noexcept | ||
{ | ||
is_shutdown_ = true; | ||
|
||
collector_->GetCollection().clear(); | ||
} | ||
|
||
/** | ||
* @return: returns a shared_ptr to | ||
* the PrometheusCollector instance | ||
*/ | ||
std::shared_ptr<PrometheusCollector> &PrometheusExporter::GetCollector() | ||
{ | ||
return collector_; | ||
} | ||
|
||
/** | ||
* @return: Gets the shutdown status of the exporter | ||
*/ | ||
bool PrometheusExporter::IsShutdown() const | ||
{ | ||
return is_shutdown_; | ||
} | ||
|
||
} // namespace prometheus | ||
} // namespace exporter | ||
OPENTELEMETRY_END_NAMESPACE | ||
#endif // ENABLE_METRICS_PREVIEW |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The target is removed here, but I didn't see it is added back in other places but it is referenced below in
target_include_directories
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed