Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OTLP/HTTP default port from 4317 to 4318 #1018

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 19, 2021

As per the changes in the specs: open-telemetry/opentelemetry-specification#1970
This could be the BREAKING change, but since the collector never moved to 4317 for grpc-http ( as per its commit history ), it shouldn't affect many customers.

Note: this is still in process of reservation with IANA (open-telemetry/opentelemetry-specification#1970 (comment) )

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team October 19, 2021 05:25
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1018 (cd3f475) into main (096c08b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files         161      161           
  Lines        6833     6833           
=======================================
  Hits         6519     6519           
  Misses        314      314           

@ThomsonTan ThomsonTan merged commit bfab71a into open-telemetry:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants