Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WITH_REMOVE_METER_PREVIEW, use WITH_ABI_VERSION_2 instead #2363

Closed
marcalff opened this issue Oct 12, 2023 · 3 comments · Fixed by #2370
Closed

Remove WITH_REMOVE_METER_PREVIEW, use WITH_ABI_VERSION_2 instead #2363

marcalff opened this issue Oct 12, 2023 · 3 comments · Fixed by #2370
Assignees
@marcalff
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

The feature WITH_REMOVE_METER_PREVIEW was implemented before ABI version 2 was defined.

It makes no sense to keep WITH_REMOVE_METER_PREVIEW now,
rework CMakeLists.txt to expose this feature in WITH_ABI_VERSION_2.
@marcalff marcalff added the bug Something isn't working label Oct 12, 2023
@marcalff marcalff self-assigned this Oct 12, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 12, 2023
@lalitb
Copy link
Member

lalitb commented Oct 12, 2023

Agree

@IamVishalSharma
Copy link

@marcalff Could you please tell how i can build for: ENABLE_REMOVE_METER_PREVIEW. i was trying below
sudo cmake .. -DBUILD_SHARED_LIBS=ON -DWITH_OTLP_GRPC=ON -DWITH_OTLP_HTTP=ON -DWITH_PROMETHEUS=OFF -DBUILD_TESTING=OFF -DWITH_EXAMPLES_HTTP=ON -DWITH_ABSEIL=ON -DENABLE_REMOVE_METER_PREVIEW=ON

@marcalff
Copy link
Member Author

The option name is WITH_REMOVE_METER_PREVIEW, see:

https://github.com/open-telemetry/opentelemetry-cpp/blob/main/CMakeLists.txt#L233-L239

To use it from CMake, use -DWITH_REMOVE_METER_PREVIEW=ON

marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Oct 16, 2023
@marcalff
Fixes open-telemetry#2363
b077920
@marcalff marcalff mentioned this issue Oct 16, 2023
Merged
3 tasks
@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Remove WITH_REMOVE_METER_PREVIEW, use WITH_ABI_VERSION_2 instead marcalff/opentelemetry-cpp
3 participants
@lalitb @IamVishalSharma @marcalff