Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics API/SDK] Add InstrumentationScope attributes in MeterProvider::GetMeter() #2033

Closed
lalitb opened this issue Mar 8, 2023 · 1 comment · Fixed by #2224
Closed

[Metrics API/SDK] Add InstrumentationScope attributes in MeterProvider::GetMeter() #2033

lalitb opened this issue Mar 8, 2023 · 1 comment · Fixed by #2224
Assignees
@marcalff
Labels
abi:version_2 Fix is available WITH_ABI_VERSION_2 breaking change API or ABI breaking change do-not-stale
Milestone
Metrics post GA r...

Comments

@lalitb
Copy link
Member

lalitb commented Mar 8, 2023 •
edited by marcalff
Loading

As mentioned in the specs, it should be possible to optionally pass the InstrumentationScope attributes while creating/fetching a Meter through MeterProvider.

Get a Meter

This API MUST accept the following parameters:
 * name (required)
 * version (optional)
 * [since 1.4.0] schema_url (optional)
 * [since 1.13.0] attributes (optional)

With #2004, the InstrumentationScope class already support storing the attributes.

The relevant metric exporters - OTLP, OStream, Prometheus(?) should be modified to support sending/dumping these attributes.

Also this would be an API/ABI breaking change (modifying/overloading the virtual method in the API), so need to be planned accordingly.
@lalitb lalitb changed the title [Metrics API/SDK] [Metrics API/SDK] Add InstrumentationScope attributes in MeterProvider::GetMeter() Mar 8, 2023
@lalitb lalitb added the breaking change API or ABI breaking change label Mar 8, 2023
@lalitb lalitb mentioned this issue Mar 8, 2023
Closed
@lalitb lalitb added this to the Metrics post GA release milestone Mar 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label May 9, 2023
@esigo esigo added do-not-stale and removed Stale labels May 14, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 7, 2023
@marcalff
Proof of concept.
fdbef73 
Fixes open-telemetry#2033
@marcalff marcalff mentioned this issue Jul 7, 2023
Merged
3 tasks
@marcalff marcalff self-assigned this Sep 26, 2023
@marcalff marcalff added the abi:version_2 Fix is available WITH_ABI_VERSION_2 label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
abi:version_2 Fix is available WITH_ABI_VERSION_2 breaking change API or ABI breaking change do-not-stale
Projects
None yet
Milestone
Metrics post GA release - 1
Development

Successfully merging a pull request may close this issue.

[API] Add InstrumentationScope attributes in MeterProvider::GetMeter() marcalff/opentelemetry-cpp
3 participants
@lalitb @marcalff @esigo