We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per the spec:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md
boolean environment variables should accept "true" or "false", with case insensitive comparison.
Other values should cause a warnings.
Per the code:
inline bool GetOtlpDefaultIsSslEnable() { constexpr char kOtlpTracesIsSslEnableEnv[] = "OTEL_EXPORTER_OTLP_TRACES_SSL_ENABLE"; constexpr char kOtlpIsSslEnableEnv[] = "OTEL_EXPORTER_OTLP_SSL_ENABLE"; auto ssl_enable = opentelemetry::sdk::common::GetEnvironmentVariable(kOtlpTracesIsSslEnableEnv); if (ssl_enable.empty()) { ssl_enable = opentelemetry::sdk::common::GetEnvironmentVariable(kOtlpIsSslEnableEnv); } if (ssl_enable == "True" || ssl_enable == "TRUE" || ssl_enable == "true" || ssl_enable == "1") { return true; } return false; }
Issues:
TrUe
true
Beside, this code has been copied and pasted all other the place, some cleanup is needed.
The text was updated successfully, but these errors were encountered:
This issue was marked as stale due to lack of activity.
Sorry, something went wrong.
Fixes open-telemetry#1859
98de43b
[EXPORTER] Boolean environment variables not parsed per the spec
marcalff
Successfully merging a pull request may close this issue.
Per the spec:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md
boolean environment variables should accept "true" or "false", with case insensitive comparison.
Other values should cause a warnings.
Per the code:
Issues:
TrUe
should betrue
Beside, this code has been copied and pasted all other the place, some cleanup is needed.
The text was updated successfully, but these errors were encountered: