Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Build break on macOS 12 #1778

Closed
marcalff opened this issue Nov 16, 2022 · 1 comment · Fixed by #1779
Closed

[BUILD] Build break on macOS 12 #1778

marcalff opened this issue Nov 16, 2022 · 1 comment · Fixed by #1779
Assignees
Labels
bug Something isn't working build and test

Comments

@marcalff
Copy link
Member

The github macOS-latest label has changed from macOS-11 to macOS-12

actions/runner-images#6384

This exposes a new build break when compiling opentelemetry-cpp with all dependencies:

external/com_google_absl/absl/functional/function_ref.h:124:16: error: definition of implicit copy constructor for 'FunctionRef<void (absl::string_view)>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  FunctionRef& operator=(const FunctionRef& rhs) = delete;
               ^
external/com_google_absl/absl/strings/cord.h:1325:33: note: in implicit copy constructor for 'absl::FunctionRef<void (absl::string_view)>' first required here
    return ForEachChunkAux(rep, callback);
                                ^
1 error generated.

Somehow this code is built with [-Werror,-Wdeprecated-copy], causing the warning to fail as an error.

Note that CLang was also changed from version 13.0 to 14.0.

@marcalff marcalff added bug Something isn't working build and test labels Nov 16, 2022
@marcalff marcalff self-assigned this Nov 16, 2022
@marcalff
Copy link
Member Author

Caused by:

abseil/abseil-cpp#948

Fixed in Abseil by this commit:

abseil/abseil-cpp@702cae1

marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Nov 16, 2022
Bazel build:
Upgrade Abseil to abseil-cpp-20220623.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build and test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant