Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Multiple CURL packages leads to invalid build. #1738

Closed
marcalff opened this issue Nov 7, 2022 · 0 comments · Fixed by #1739
Closed

[Build] Multiple CURL packages leads to invalid build. #1738

marcalff opened this issue Nov 7, 2022 · 0 comments · Fixed by #1739
Assignees
Labels
bug Something isn't working build and test

Comments

@marcalff
Copy link
Member

marcalff commented Nov 7, 2022

Assume a machine with:

  • a CURL package, version A, installed in system headers
  • a CURL package, version B, installed elsewhere.

During CMake, package B is found, which is the expected result.

In ./ext/src/http/client/curl/CMakeLists.txt, the makefile adds the proper include directory:

    target_include_directories(opentelemetry_http_client_curl
                               INTERFACE "${CURL_INCLUDE_DIRS}")

which points to package B, as expected.

During the build however, the following line of code:

#include <curl/curl.h>

does not see header files from B, but uses A instead.

The compiler does not uses the include path given by the makefile, and uses the system package.

Code is build with header files that do not match libraries, leading to an inconsistent build.

Please fix ext/include/opentelemetry/ext/http/client/curl/http_operation_curl.h
to use quotes, not curly brackets, when including the curl header files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build and test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant