Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] More build warnings #1616

Closed
marcalff opened this issue Sep 14, 2022 · 0 comments · Fixed by #1620
Closed

[BUILD] More build warnings #1616

marcalff opened this issue Sep 14, 2022 · 0 comments · Fixed by #1620
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

Fix build warnings reported by -Werror=overloaded-virtual in gcc

For example:

In file included from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/context/context_value.h:13,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/context/context.h:7,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/trace/tracer.h:6,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/detail/tracer_handle.h:6,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/tracer.h:10,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/factory.h:9,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/detail/dynamic_load_unix.h:12,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/dynamic_load.h:11,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/test/plugin/dynamic_load_test.cc:4:
/home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/trace/span.h:63:16: error: ‘virtual void opentelemetry::v1::trace::Span::AddEvent(opentelemetry::v1::nostd::string_view, const opentelemetry::v1::common::KeyValueIterable&)’ was hidden [-Werror=overloaded-virtual]
   63 |   virtual void AddEvent(nostd::string_view name,
      |                ^~~~~~~~
In file included from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/factory.h:9,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/detail/dynamic_load_unix.h:12,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/dynamic_load.h:11,
                 from /home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/test/plugin/dynamic_load_test.cc:4:
/home/malff/CODE/MARC_GITHUB/opentelemetry-cpp/api/include/opentelemetry/plugin/tracer.h:37:8: note:   by ‘opentelemetry::v1::plugin::Span::AddEvent’
   37 |   void AddEvent(nostd::string_view name,
      |        ^~~~~~~~
cc1plus: all warnings being treated as errors
@marcalff marcalff added the bug Something isn't working label Sep 14, 2022
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Sep 19, 2022
@marcalff
Fix more build warnings (open-telemetry#1616)
15f915e
@marcalff marcalff mentioned this issue Sep 19, 2022
Merged
3 tasks
lalitb pushed a commit that referenced this issue Sep 20, 2022
@marcalff
Fix more build warnings (#1616) (#1620)
85b7878
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this issue Dec 5, 2022
@marcalff @yxue
Fix more build warnings (open-telemetry#1616) (open-telemetry#1620)
6aed2da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix more build warnings (#1616) marcalff/opentelemetry-cpp
1 participant
@marcalff