Fix memory leak in TlsRandomNumberGenerator() constructor #2660

open-telemetry · May 7, 2024 · c2ce0fb · c2ce0fb
1 parent da8e377
commit c2ce0fb
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/sdk/src/common/random.cc b/sdk/src/common/random.cc
@@ -6,6 +6,7 @@
 #include "src/common/platform/fork.h"
 
 #include <cstring>
+#include <mutex>
 #include <random>
 
 OPENTELEMETRY_BEGIN_NAMESPACE
@@ -20,13 +21,14 @@ namespace common
 //     https://github.com/opentracing-contrib/nginx-opentracing/issues/52
 namespace
 {
+static std::once_flag once;
 class TlsRandomNumberGenerator
 {
 public:
   TlsRandomNumberGenerator() noexcept
   {
     Seed();
-    platform::AtFork(nullptr, nullptr, OnFork);
+    std::call_once(once, [](){ platform::AtFork(nullptr, nullptr, OnFork); });
   }
 
   static FastRandomNumberGenerator &engine() noexcept { return engine_; }