Implement span context shim trace_id and span_id

open-telemetry · Jan 5, 2023 · 8f10779 · 8f10779
1 parent 25aeac8
commit 8f10779
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/opentracing-shim/include/span_context_shim.h b/opentracing-shim/include/span_context_shim.h
@@ -28,8 +28,18 @@ class SpanContextShim final : public opentracing::SpanContext
   using VisitBaggageItem = std::function<bool(const std::string& key, const std::string& value)>;
   void ForeachBaggageItem(VisitBaggageItem f) const override;
   std::unique_ptr<opentracing::SpanContext> Clone() const noexcept override;
+  std::string ToTraceID() const noexcept override;
+  std::string ToSpanID() const noexcept override;
 
 private:
+  template <typename T>
+  static std::string toHexString(const T &id_item)
+  {
+    char buf[T::kSize * 2];
+    id_item.ToLowerBase16(buf);
+    return std::string(buf, sizeof(buf));
+  }
+
   opentelemetry::trace::SpanContext context_;
   BaggagePtr baggage_;
 };

diff --git a/opentracing-shim/src/span_context_shim.cc b/opentracing-shim/src/span_context_shim.cc
@@ -33,5 +33,15 @@ std::unique_ptr<opentracing::SpanContext> SpanContextShim::Clone() const noexcep
   return std::unique_ptr<SpanContextShim>(new (std::nothrow) SpanContextShim(context_, baggage_));
 }
 
+std::string SpanContextShim::ToTraceID() const noexcept
+{
+  return toHexString(context_.trace_id());
+}
+
+std::string SpanContextShim::ToSpanID() const noexcept
+{
+  return toHexString(context_.span_id());
+}
+
 } // namespace opentracingshim
 OPENTELEMETRY_END_NAMESPACE
diff --git a/opentracing-shim/test/tracer_shim_test.cc b/opentracing-shim/test/tracer_shim_test.cc
@@ -181,4 +181,4 @@ TEST_F(TracerShimTest, ExtractOnlyBaggage)
   std::string value;
   ASSERT_TRUE(span_context_shim->BaggageItem("foo", value));
   ASSERT_EQ(value, "bar");
-}
+}