Skip to content

Commit

Permalink
[DOC] Remove comment for unused LoggerProvider initialization params (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
herman5 authored Jun 30, 2024
1 parent ead2d1b commit 5e21b8a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions sdk/include/opentelemetry/sdk/logs/logger_provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ class OPENTELEMETRY_EXPORT LoggerProvider final : public opentelemetry::logs::Lo
* @param processor The span processor for this logger provider. This must
* not be a nullptr.
* @param resource The resources for this logger provider.
* @param sampler The sampler for this logger provider. This must
* not be a nullptr.
* @param id_generator The custom id generator for this logger provider. This must
* not be a nullptr
*/
explicit LoggerProvider(std::unique_ptr<LogRecordProcessor> &&processor,
opentelemetry::sdk::resource::Resource resource =
Expand Down

1 comment on commit 5e21b8a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 5e21b8a Previous: ead2d1b Ratio
BM_SpinLockThrashing/2/process_time/real_time 1.5168190002441406 ms/iter 0.18686984343264862 ms/iter 8.12
BM_SpinLockThrashing/4/process_time/real_time 2.3265884768578315 ms/iter 0.9309038137778257 ms/iter 2.50
BM_NaiveSpinLockThrashing/4/process_time/real_time 1.5016555786132812 ms/iter 0.7231350251060119 ms/iter 2.08

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.