Align with naming conventions

open-telemetry · Nov 2, 2024 · 5dc28ab · 5dc28ab
1 parent d0b8589
commit 5dc28ab
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/ext/include/opentelemetry/ext/http/client/curl/http_client_curl.h b/ext/include/opentelemetry/ext/http/client/curl/http_client_curl.h
@@ -102,7 +102,7 @@ class Request : public opentelemetry::ext::http::client::Request
     compression_ = compression;
   }
 
-  void EnableLogging(bool needs_to_log) noexcept override { needs_to_log_ = needs_to_log; }
+  void EnableLogging(bool is_log_enabled) noexcept override { is_log_enabled_ = is_log_enabled; }
 
 public:
   opentelemetry::ext::http::client::Method method_;
@@ -113,7 +113,7 @@ class Request : public opentelemetry::ext::http::client::Request
   std::chrono::milliseconds timeout_ms_{5000};  // ms
   opentelemetry::ext::http::client::Compression compression_{
       opentelemetry::ext::http::client::Compression::kNone};
-  bool needs_to_log_{false};
+  bool is_log_enabled_{false};
 };
 
 class Response : public opentelemetry::ext::http::client::Response

diff --git a/ext/include/opentelemetry/ext/http/client/curl/http_operation_curl.h b/ext/include/opentelemetry/ext/http/client/curl/http_operation_curl.h
@@ -159,7 +159,7 @@ class HttpOperation
                 bool is_raw_response                        = false,
                 std::chrono::milliseconds http_conn_timeout = default_http_conn_timeout,
                 bool reuse_connection                       = false,
-                bool needs_to_log                           = false);
+                bool is_log_enabled                         = false);
 
   /**
    * Destroy CURL instance
@@ -307,7 +307,7 @@ class HttpOperation
 
   const opentelemetry::ext::http::client::Compression &compression_;
 
-  const bool needs_to_log_;
+  const bool is_log_enabled_;
 
   // Processed response headers and body
   long response_code_;

diff --git a/ext/include/opentelemetry/ext/http/client/http_client.h b/ext/include/opentelemetry/ext/http/client/http_client.h
@@ -245,7 +245,7 @@ class Request
 
   virtual void SetCompression(const Compression &compression) noexcept = 0;
 
-  virtual void EnableLogging(bool needs_to_log) noexcept = 0;
+  virtual void EnableLogging(bool is_log_enabled) noexcept = 0;
 
   virtual ~Request() = default;
 };

diff --git a/ext/src/http/client/curl/http_client_curl.cc b/ext/src/http/client/curl/http_client_curl.cc
@@ -119,7 +119,7 @@ void Session::SendRequest(
   curl_operation_.reset(new HttpOperation(
       http_request_->method_, url, http_request_->ssl_options_, callback_ptr,
       http_request_->headers_, http_request_->body_, http_request_->compression_, false,
-      http_request_->timeout_ms_, reuse_connection, http_request_->needs_to_log_));
+      http_request_->timeout_ms_, reuse_connection, http_request_->is_log_enabled_));
   bool success =
       CURLE_OK == curl_operation_->SendAsync(this, [this, callback](HttpOperation &operation) {
         if (operation.WasAborted())

diff --git a/ext/src/http/client/curl/http_operation_curl.cc b/ext/src/http/client/curl/http_operation_curl.cc
@@ -263,7 +263,7 @@ HttpOperation::HttpOperation(opentelemetry::ext::http::client::Method method,
                              bool is_raw_response,
                              std::chrono::milliseconds http_conn_timeout,
                              bool reuse_connection,
-                             bool needs_to_log)
+                             bool is_log_enabled)
     : is_aborted_(false),
       is_finished_(false),
       is_cleaned_(false),
@@ -283,7 +283,7 @@ HttpOperation::HttpOperation(opentelemetry::ext::http::client::Method method,
       request_nwrite_(0),
       session_state_(opentelemetry::ext::http::client::SessionState::Created),
       compression_(compression),
-      needs_to_log_(needs_to_log),
+      is_log_enabled_(is_log_enabled),
       response_code_(0)
 {
   /* get a curl handle */
@@ -658,7 +658,7 @@ CURLcode HttpOperation::Setup()
     return rc;
   }
 #else
-  rc = SetCurlLongOption(CURLOPT_VERBOSE, static_cast<long>(needs_to_log_ || kEnableCurlLogging));
+  rc = SetCurlLongOption(CURLOPT_VERBOSE, static_cast<long>(is_log_enabled_ || kEnableCurlLogging));
   if (rc != CURLE_OK)
   {
     return rc;

diff --git a/test_common/include/opentelemetry/test_common/ext/http/client/nosend/http_client_nosend.h b/test_common/include/opentelemetry/test_common/ext/http/client/nosend/http_client_nosend.h
@@ -69,7 +69,7 @@ class Request : public opentelemetry::ext::http::client::Request
     compression_ = compression;
   }
 
-  void EnableLogging(bool needs_to_log) noexcept override { needs_to_log_ = needs_to_log; }
+  void EnableLogging(bool is_log_enabled) noexcept override { is_log_enabled_ = is_log_enabled; }
 
 public:
   opentelemetry::ext::http::client::Method method_;
@@ -80,7 +80,7 @@ class Request : public opentelemetry::ext::http::client::Request
   std::chrono::milliseconds timeout_ms_{5000};  // ms
   opentelemetry::ext::http::client::Compression compression_{
       opentelemetry::ext::http::client::Compression::kNone};
-  bool needs_to_log_{false};
+  bool is_log_enabled_{false};
 };
 
 class Response : public opentelemetry::ext::http::client::Response