Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
true should be returned from Null object pattern to indicate success
Browse files Browse the repository at this point in the history
maxgolov committed Apr 2, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 80512b5 commit 550f2d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion api/include/opentelemetry/trace/span_context_kv_iterable.h
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ class NullSpanContext : public SpanContextKeyValueIterable
nostd::function_ref<bool(SpanContext, const opentelemetry::common::KeyValueIterable &)>
callback) const noexcept override
{
return false;
return true;
}

size_t size() const noexcept override { return 0; };

0 comments on commit 550f2d8

Please sign in to comment.