Skip to content

Commit

Permalink
[EXPORTER] OTLP: Fix missing ResourceMetrics SchemaURL (#2587)
Browse files Browse the repository at this point in the history
  • Loading branch information
@perhapsmaple
perhapsmaple authored Mar 12, 2024
1 parent 25738f3 commit 19f0dc7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions exporters/otlp/src/otlp_metric_utils.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ void OtlpMetricUtils::PopulateResourceMetrics(
proto::common::v1::InstrumentationScope *scope = scope_lib_metrics->mutable_scope();
scope->set_name(scope_metrics.scope_->GetName());
scope->set_version(scope_metrics.scope_->GetVersion());
resource_metrics->set_schema_url(scope_metrics.scope_->GetSchemaURL());

for (auto &metric_data : scope_metrics.metric_data_)
{
Expand Down

1 comment on commit 19f0dc7

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 19f0dc7 Previous: 25738f3 Ratio
BM_ProcYieldSpinLockThrashing/4/process_time/real_time 3.968820571899414 ms/iter 0.7112877709524972 ms/iter 5.58
BM_NaiveSpinLockThrashing/1/process_time/real_time 0.2205824851989746 ms/iter 0.09221107108366915 ms/iter 2.39
BM_ThreadYieldSpinLockThrashing/1/process_time/real_time 19.48564052581787 ms/iter 7.345714067157946 ms/iter 2.65

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.