[user_events] Set EventHeader name to the event_name property#533
Merged
ThomsonTan merged 7 commits intoopen-telemetry:mainfrom Mar 12, 2025
Merged
[user_events] Set EventHeader name to the event_name property#533ThomsonTan merged 7 commits intoopen-telemetry:mainfrom
ThomsonTan merged 7 commits intoopen-telemetry:mainfrom
Conversation
lalitb
reviewed
Mar 12, 2025
| return; | ||
| } | ||
|
|
||
| auto event_name = !event_name_.empty() ? event_name_.data() : "OpenTelemetryLogs"; |
Member
There was a problem hiding this comment.
otel-rust uses default as "Logs". Either is fine, as long as long as we are consistent. cc @cijothomas.
lalitb
approved these changes
Mar 12, 2025
Member
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. With nit comment. Thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With below PR in main, the user_events Log exporter could create
EventBuilderduring calling intoRecordablewithevent_name, and also no need to cache the Log attributes which would require extra dynamic memory allocation.open-telemetry/opentelemetry-cpp#3296