Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nginx): opentelemetry-cpp v1.0.0-rc3 #45

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

johanneswuerbach
Copy link
Contributor

@johanneswuerbach johanneswuerbach requested a review from seemk as a code owner July 13, 2021 18:15
@johanneswuerbach johanneswuerbach requested a review from a team July 13, 2021 18:15
@@ -17,7 +17,7 @@ extern ngx_module_t otel_ngx_module;
#include "nginx_utils.h"
#include "propagate.h"
#include <opentelemetry/context/context.h>
#include <opentelemetry/exporters/otlp/otlp_exporter.h>
#include <opentelemetry/exporters/otlp/otlp_grpc_exporter.h>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@seemk seemk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That was fast 😄

@@ -44,4 +45,5 @@ target_link_libraries(otel_ngx_module
${OPENTELEMETRY_CPP_LIBRARIES}
gRPC::grpc++
CURL::libcurl
nlohmann_json::nlohmann_json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming from open-telemetry/opentelemetry-cpp#810, not sure if we should attempt to drop this as OTLP/HTTP+JSON exporter isn't used at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it build when not using find_package(nlohmann_json) and not linking to it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope :-(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otel CPP external dependencies are starting to get a bit out of hand, wish it had none and would be distributed as a single library file. 😄

Anyway, thanks for the PR!

@seemk seemk merged commit 01ee1ae into open-telemetry:main Jul 13, 2021
@marcalff marcalff added the instrumentation:nginx Nginx module label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants