feat(nginx): opentelemetry-cpp v1.0.0-rc3 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ extern ngx_module_t otel_ngx_module; | |||
| #include "nginx_utils.h" | |||
| #include "propagate.h" | |||
| #include <opentelemetry/context/context.h> | |||
| #include <opentelemetry/exporters/otlp/otlp_exporter.h> | |||
| #include <opentelemetry/exporters/otlp/otlp_grpc_exporter.h> | |||
There was a problem hiding this comment.
This was due to open-telemetry/opentelemetry-cpp#810
| @@ -44,4 +45,5 @@ target_link_libraries(otel_ngx_module | |||
| ${OPENTELEMETRY_CPP_LIBRARIES} | |||
| gRPC::grpc++ | |||
| CURL::libcurl | |||
| nlohmann_json::nlohmann_json | |||
There was a problem hiding this comment.
This is coming from open-telemetry/opentelemetry-cpp#810, not sure if we should attempt to drop this as OTLP/HTTP+JSON exporter isn't used at the moment.
There was a problem hiding this comment.
Does it build when not using find_package(nlohmann_json) and not linking to it?
There was a problem hiding this comment.
Otel CPP external dependencies are starting to get a bit out of hand, wish it had none and would be distributed as a single library file. 😄
Anyway, thanks for the PR!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to https://github.com/open-telemetry/opentelemetry-cpp/releases/tag/v1.0.0-rc3