-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nginx): opentelemetry-cpp v1.0.0-rc3 #45
Conversation
@@ -17,7 +17,7 @@ extern ngx_module_t otel_ngx_module; | |||
#include "nginx_utils.h" | |||
#include "propagate.h" | |||
#include <opentelemetry/context/context.h> | |||
#include <opentelemetry/exporters/otlp/otlp_exporter.h> | |||
#include <opentelemetry/exporters/otlp/otlp_grpc_exporter.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was due to open-telemetry/opentelemetry-cpp#810
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That was fast 😄
@@ -44,4 +45,5 @@ target_link_libraries(otel_ngx_module | |||
${OPENTELEMETRY_CPP_LIBRARIES} | |||
gRPC::grpc++ | |||
CURL::libcurl | |||
nlohmann_json::nlohmann_json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming from open-telemetry/opentelemetry-cpp#810, not sure if we should attempt to drop this as OTLP/HTTP+JSON exporter
isn't used at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it build when not using find_package(nlohmann_json)
and not linking to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otel CPP external dependencies are starting to get a bit out of hand, wish it had none and would be distributed as a single library file. 😄
Anyway, thanks for the PR!
Bump to https://github.com/open-telemetry/opentelemetry-cpp/releases/tag/v1.0.0-rc3