Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nginx): set error status on span with 5xx status code #443

Merged

Conversation

dmehala
Copy link

@dmehala dmehala commented May 15, 2024

Description

This PR enhances the otel_ngx_module to set the span status as "error" specifically when the HTTP request returns a 5xx status code. For all other status codes, it sets the status as "ok".

Copy link

linux-foundation-easycla bot commented May 15, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@dmehala dmehala marked this pull request as ready for review May 15, 2024 13:17
@dmehala dmehala requested a review from a team May 15, 2024 13:17
@dmehala dmehala changed the title [WIP] fix: set error status on span with 5xx status code fix: set error status on span with 5xx status code May 15, 2024
@marcalff marcalff added the instrumentation:nginx Nginx module label May 15, 2024
@marcalff marcalff changed the title fix: set error status on span with 5xx status code fix(nginx): set error status on span with 5xx status code May 15, 2024
@dmehala
Copy link
Author

dmehala commented May 30, 2024

Hello @marcalff @seemk @tobiasstadler ,

Do you have an estimated timeline? My understanding is that the otel-webserver-module is the new implementation. However, if I am not mistaken, this module is used by ingress-nginx to provide tracing, and this fix would benefit the entire community.

EDIT: I confirm ingress-nginx use otel_ngx_module - https://github.com/kubernetes/ingress-nginx/blob/1d3493018086ef6a1643686781a5d11707beed6d/images/opentelemetry/rootfs/build.sh#L113-L162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants