Change instrument type refs from observable to asynchronous#446
Closed
jack-berg wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Change instrument type refs from observable to asynchronous#446jack-berg wants to merge 2 commits intoopen-telemetry:mainfrom
jack-berg wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
…y-configuration into observable-to-asynchronous
codeboten
reviewed
Dec 5, 2025
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
other implementations (go, python) use observable
Member
Author
|
I am fine with keeping it as observable. It would be a breaking change which I'd probably characterize as not low impact, so maybe the bar needs to be higher to justify. |
Contributor
|
Maybe this is a consistency we address once implementations have renamed their apis from observable to asynchronous 🤷🏻 |
Member
Author
|
Closing. Since multiple language implementations and the spec use "observable" at least some of the time, its fair to say that "observable" is an alias for "asynchronous". Changing to "asynchronous" isn't worth the churn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec uses both "observable" and "asynchronous" to describe metric instruments which are invoked by callback.
I think I carried "observable" over from the java implementation. We can keep it, but if we prefer better alignment with the spec now is the time to change it.