Skip to content

adds descriptions for aggregation types#436

Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom
codeboten:codeboten/add-description-aggregations
Dec 2, 2025
Merged

adds descriptions for aggregation types#436
jack-berg merged 3 commits intoopen-telemetry:mainfrom
codeboten:codeboten/add-description-aggregations

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

The contents were pulled directly from the spec https://opentelemetry.io/docs/specs/otel/metrics/sdk/#aggregation

@codeboten codeboten requested a review from a team as a code owner November 27, 2025 22:16
Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on phrasing consistency?

I.e. "The drop aggregation informs the sdk to..." vs "Configure the stream to use the drop aggregation./The drop aggregation informs the sdk to.."

@codeboten
Copy link
Copy Markdown
Contributor Author

@jack-berg i updated the description, please take a look. I wanted to keep some details about the meaning of each aggregation type as i find this information useful when i tested using the schema to provide tooltips

The contents were pulled directly from the spec https://opentelemetry.io/docs/specs/otel/metrics/sdk/#aggregation

Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten force-pushed the codeboten/add-description-aggregations branch from 5442de2 to bfdb79c Compare December 2, 2025 20:49
@jack-berg jack-berg merged commit 3208b18 into open-telemetry:main Dec 2, 2025
12 checks passed
@codeboten codeboten deleted the codeboten/add-description-aggregations branch December 2, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants