-
Notifications
You must be signed in to change notification settings - Fork 38
Add schema for rule based sampler #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4764b55
Add schema for rule based sampler
anuraaga 397d5c4
Fix
anuraaga d5d1a00
Cleanup
anuraaga 357a871
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
anuraaga 5d823c0
Begin merge
anuraaga 88ae928
Indent
anuraaga 1369994
Continue
anuraaga b94c3fd
Restore
anuraaga b12aa1c
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
jack-berg 2d7e634
Cleanup and parent type
anuraaga 7bf0452
Inline includes
anuraaga 6da72e1
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
anuraaga 30be8a7
Cleanup
anuraaga add58ab
Fix
anuraaga ce8dbc9
default behavior
anuraaga 27e8eee
Start merge
anuraaga 7f21223
Generate
anuraaga 8769d79
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
jack-berg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that a useful predicate for rule based sampling is
no_local_parent, which nicely identifies service head spans. This, of course, in addition tois_trace_root. I realize that the proposedparentrule is expressive enough, but it is more verbose.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with keeping the parent enum since then we don't have to worry about "what if both are set" type of situations. I guess in terms of verbosity,
parent: LOCALis similar tono_local_parent: true? Possibly helped by removing the SAMPLED state from the enum, let me know if it looks fine now