WIP: add descriptions to schema#396
Closed
codeboten wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Conversation
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Contributor
Author
|
I think #411 makes more sense for this repository. Closing this PR in favour of the other one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting together a prototype of putting descriptions back in the json schema. This will improve any implementation that uses code generation that supports using the
descriptionfield in a meaningful way (ie. docstrings).Additionally, anyone consuming the schema only will benefit from this.
Fixes #398