Add schema for composite sampler#390
Merged
jack-berg merged 5 commits intoopen-telemetry:mainfrom Nov 7, 2025
Merged
Conversation
jack-berg
reviewed
Nov 6, 2025
| "maxProperties": 1, | ||
| "properties": { | ||
| "always_off": { | ||
| "$ref": "#/$defs/AlwaysOffSampler" |
Member
There was a problem hiding this comment.
Consistency with ExperimentalComposableParentBasedSampler would suggest separate ExperimentalComposableAlwaysOn/ExperimentalComposableAlwaysOff sampler as defined in the spec, but it seems silly at the same time.
Contributor
Author
There was a problem hiding this comment.
Indeed felt a bit silly but went with it - from a configuration standpoint it shouldn't matter, but we could imagine implementations in SDKs that map these types to actual SDK types in which case the mapping would be incorrect.
jack-berg
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #340
Essentially proposal from here but left out
delegate:#340 (comment)
Didn't actually agree on concensus in the issue so happy to make any changes, just wanted to keep the ball rolling.