Skip to content

Update prometheus exporter properties to match the spec#376

Merged
jack-berg merged 6 commits intoopen-telemetry:mainfrom
zeitlinger:without_scope_info
Nov 15, 2025
Merged

Update prometheus exporter properties to match the spec#376
jack-berg merged 6 commits intoopen-telemetry:mainfrom
zeitlinger:without_scope_info

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

@zeitlinger zeitlinger commented Nov 5, 2025

Prom spec update: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/prometheus.md#configuration

  • without_target_info has added
  • without_scope_info has a new meaning - it affects scope labels now (before: scope metric)

@zeitlinger zeitlinger requested a review from a team as a code owner November 5, 2025 08:49
Comment thread schema/meter_provider.json
@zeitlinger zeitlinger changed the title remove without_scope_info Update prometheus exporter properties to match the spec Nov 7, 2025
@zeitlinger
Copy link
Copy Markdown
Member Author

@jack-berg can you check again?

Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread schema/meta_schema_language_go.yaml Outdated
- property: without_scope_info
status: unknown
- property: without_target_info
status: unknown
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nit: Technically unnecessary since the entire ExperimentalPrometheusMetricExporter has status unknown

Comment thread schema/meter_provider.json
Comment thread schema/meter_provider.json
Comment thread schema/meta_schema_types.yaml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants