Add meta schema support for enum types#367
Merged
jack-berg merged 5 commits intoopen-telemetry:mainfrom Nov 4, 2025
Merged
Conversation
codeboten
approved these changes
Nov 3, 2025
Contributor
codeboten
left a comment
There was a problem hiding this comment.
This makes sense to me
MrAlias
approved these changes
Nov 3, 2025
…y-configuration into meta-schema-enum-support
…rg/opentelemetry-configuration into meta-schema-enum-support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marcalff's comment here made me realize that meta schema support for enum types is bad, preventing us from describing each individual enum value, and from setting language implementation support status for each individual enum value.
This improves it.
meta_schema_types.yamlnow has either.propertiesor.enumValuesbased on whether its an object or enum typemeta_schema_languages_{language}.yamlnow has either.propertyOverridesor.enumOverridesbased on whether its an object or enum typeschema-docs.mdnow recognizes the enum types from object types, and displays enum types better, for example: