Skip to content

Mark resource detectors experimental #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 4 commits into from
Mar 6, 2025
Merged

Mark resource detectors experimental #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51f7e28
Mark resource detectors experimental
jack-berg Mar 3, 2025
cf7e07d
Merge branch 'main' into experimental-detectors
jack-berg Mar 4, 2025
5cb21b0
Merge branch 'main' into experimental-detectors
jack-berg Mar 6, 2025
ac8fcdd
Merge branch 'main' into experimental-detectors
jack-berg Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/kitchen-sink.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,8 @@ resource:
# If omitted or null, no resource attributes are added.
attributes_list: "service.namespace=my-namespace,service.version=1.0.0"
# Configure resource detectors.
detectors:
# This type is in development and subject to breaking changes in minor versions.
detectors/development:
# Configure attributes provided by resource detectors.
attributes:
# Configure list of attribute key patterns to include from resource detectors.
Expand Down
6 changes: 3 additions & 3 deletions schema/resource.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"$ref": "#/$defs/AttributeNameValue"
}
},
"detectors": {
"$ref": "#/$defs/Detectors"
"detectors/development": {
"$ref": "#/$defs/ExperimentalDetectors"
},
"schema_url": {
"type": ["string", "null"]
Expand Down Expand Up @@ -61,7 +61,7 @@
"double_array"
]
},
"Detectors": {
"ExperimentalDetectors": {
"type": "object",
"additionalProperties": false,
"properties": {
Expand Down
9 changes: 6 additions & 3 deletions schema/type_descriptions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@
The value is a list of comma separated key-value pairs matching the format of OTEL_RESOURCE_ATTRIBUTES. See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#general-sdk-configuration for details.

If omitted or null, no resource attributes are added.
detectors: Configure resource detectors.
detectors/development: >
Configure resource detectors.

This type is in development and subject to breaking changes in minor versions.
schema_url: >
Configure resource schema URL.

Expand All @@ -81,7 +84,7 @@
property_descriptions:
attributes: Configure attributes provided by resource detectors.
path_patterns:
- .resource.detectors
- .resource.detectors/development

- type: DetectorAttributes
property_descriptions:
Expand All @@ -100,7 +103,7 @@
* If the value of the attribute key matches the wildcard pattern, where '?' matches any single character and '*' matches any number of characters including none.
If omitted, .included attributes are included.
path_patterns:
- .resource.detectors.attributes
- .resource.detectors/development.attributes

- type: AttributeLimits
property_descriptions:
Expand Down