Skip to content

Mark prometheus exporter as experimental #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 3 commits into from
Mar 6, 2025
Merged

Mark prometheus exporter as experimental #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83363fd
Mark prometheus exporter as experimental
jack-berg Mar 3, 2025
890bf49
Merge branch 'main' into experimental-prometheus
jack-berg Mar 4, 2025
fa8ed85
Merge branch 'main' into experimental-prometheus
jack-berg Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/kitchen-sink.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ meter_provider:
# Configure exporter.
exporter:
# Configure exporter to be prometheus.
prometheus:
# This type is in development and subject to breaking changes in minor versions.
prometheus/development:
# Configure host.
# If omitted or null, localhost is used.
host: localhost
Expand Down
6 changes: 3 additions & 3 deletions schema/meter_provider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@
"minProperties": 1,
"maxProperties": 1,
"properties": {
"prometheus": {
"$ref": "#/$defs/PrometheusMetricExporter"
"prometheus/development": {
"$ref": "#/$defs/ExperimentalPrometheusMetricExporter"
}
},
"patternProperties": {
Expand Down Expand Up @@ -181,7 +181,7 @@
"type": ["object", "null"],
"additionalProperties": false
},
"PrometheusMetricExporter": {
"ExperimentalPrometheusMetricExporter": {
"type": ["object", "null"],
"additionalProperties": false,
"properties": {
Expand Down
9 changes: 6 additions & 3 deletions schema/type_descriptions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,10 @@

- type: MetricExporter
property_descriptions:
prometheus: Configure exporter to be prometheus.
prometheus/development: >
Configure exporter to be prometheus.

This type is in development and subject to breaking changes in minor versions.
otlp_http: Configure exporter to be OTLP with HTTP transport.
otlp_grpc: Configure exporter to be OTLP with gRPC transport.
otlp_file/development: >
Expand Down Expand Up @@ -501,7 +504,7 @@
If omitted or null, false is used.
with_resource_constant_labels: Configure Prometheus Exporter to add resource attributes as metrics attributes.
path_patterns:
- .meter_provider.readers[].pull.exporter.prometheus
- .meter_provider.readers[].pull.exporter.prometheus/development
- type: PrometheusIncludeExclude
property_descriptions:
included: >
Expand All @@ -519,7 +522,7 @@
* If the value of the attribute key matches the wildcard pattern, where '?' matches any single character and '*' matches any number of characters including none.
If omitted, .included resource attributes are included.
path_patterns:
- .meter_provider.readers[].pull.exporter.prometheus.with_resource_constant_labels
- .meter_provider.readers[].pull.exporter.prometheus/development.with_resource_constant_labels

- type: View
property_descriptions:
Expand Down