Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] The MetricExporter schema is unsafe #110

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Aug 6, 2024

Fixes #109

Changes

Split MetricExporter into:

  • PushMetricExporter, which can represent otlp, console, or an extension point,
  • PullMetricExporter, which can represent prometheus, or an extension point,

This is to enforce that:

  • PeriodicMetricReader can only use a PushMetricExporter
  • PullMetricReader can only use a PullMetricExporter

@marcalff marcalff requested a review from a team August 6, 2024 22:59
@marcalff
Copy link
Member Author

marcalff commented Aug 6, 2024

Note that this is a blind push.

I could not get instructions to work to run tests:

[malff@malff-desktop opentelemetry-configuration]$ npm --version
6.14.11
[malff@malff-desktop opentelemetry-configuration]$ make
npm install
npm WARN opentelemetry-configuration No repository field.
npm WARN opentelemetry-configuration No license field.

audited 110 packages in 0.598s

57 packages are looking for funding
  run `npm fund` for details

found 1 high severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
All tools installed
/data/malff/CODE/PLAY_GITHUB/opentelemetry-configuration
└── [email protected] 

npx: installed 1 in 0.487s
command not found: compile
make: *** [Makefile:11: compile-schema] Error 1

CHANGELOG.md Outdated Show resolved Hide resolved
@jack-berg
Copy link
Member

Not sure what you're node error is all about. I use node version 18 which comes with npm version 9. Maybe we should check an .nvmrc into version control.

Co-authored-by: jack-berg <[email protected]>
@codeboten codeboten merged commit a6b2d44 into open-telemetry:main Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SCHEMA] The MetricExporter schema is unsafe
3 participants