[SCHEMA] The MetricExporter schema is unsafe #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
Changes
Split
MetricExporter
into:PushMetricExporter
, which can representotlp
,console
, or an extension point,PullMetricExporter
, which can representprometheus
, or an extension point,This is to enforce that:
PeriodicMetricReader
can only use aPushMetricExporter
PullMetricReader
can only use aPullMetricExporter