Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate command #9866

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Fixes issue where validate command was not properly printing valid values.

Link to tracking Issue:
Closes #9863

Testing:
Updated unit tests

@TylerHelmuth TylerHelmuth requested review from a team and mx-psi March 27, 2024 21:18
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (9c5bf54) to head (ae1bdf6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9866   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         353      353           
  Lines       18764    18764           
=======================================
  Hits        17101    17101           
  Misses       1335     1335           
  Partials      328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth TylerHelmuth force-pushed the fix-validate-command branch from d3072fb to ae1bdf6 Compare March 27, 2024 21:57
@dmitryax dmitryax merged commit 38316de into open-telemetry:main Mar 27, 2024
48 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 27, 2024
@TylerHelmuth TylerHelmuth deleted the fix-validate-command branch March 27, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate subcommand does not display component names on validation failure
2 participants