[chore] apply some nits to contract_checker. #9543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9543 +/- ##
==========================================
+ Coverage 90.61% 90.63% +0.01%
==========================================
Files 347 347
Lines 18236 18230 -6
==========================================
- Hits 16525 16522 -3
+ Misses 1381 1379 -2
+ Partials 330 329 -1 ☔ View full report in Codecov by Sentry. |
atoulme
changed the title
…mix receiver functions with and without pointers
atoulme
force-pushed
the
contract_checker_nits
branch
from
e757c13 to
68ab660
Compare
dmitryax
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idSetstruct used a mix of pointer and non-pointer receivers on functions, this is now uniformly using non-pointer functions.