Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][config/configopaque] Move implementation checks to test files #9430

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 30, 2024

Description:
Move implementation checks to test files. Reduces dependencies of the configopaque package.

@atoulme atoulme requested review from a team and mx-psi January 30, 2024 17:15
@bogdandrutu
Copy link
Member

@atoulme would be good to have an issue to change everywhere.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 30, 2024

@atoulme would be good to have an issue to change everywhere.

#9431 filed!

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abae649) 90.21% compared to head (3b11e8b) 90.18%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9430      +/-   ##
==========================================
- Coverage   90.21%   90.18%   -0.03%     
==========================================
  Files         345      345              
  Lines       18021    18019       -2     
==========================================
- Hits        16257    16251       -6     
- Misses       1435     1438       +3     
- Partials      329      330       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 50132d6 into open-telemetry:main Jan 30, 2024
32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants