Skip to content

Remove deprecated types and funcs from config.#6511

Merged
bogdandrutu merged 1 commit into
open-telemetry:mainfrom
bogdandrutu:rmdepconfig
Nov 14, 2022
Merged

Remove deprecated types and funcs from config.#6511
bogdandrutu merged 1 commit into
open-telemetry:mainfrom
bogdandrutu:rmdepconfig

Conversation

@bogdandrutu

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Nov 9, 2022

Copy link
Copy Markdown

Codecov Report

Base: 91.33% // Head: 91.35% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (981de0f) compared to base (c939d8d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6511      +/-   ##
==========================================
+ Coverage   91.33%   91.35%   +0.01%     
==========================================
  Files         242      241       -1     
  Lines       13888    13885       -3     
==========================================
  Hits        12684    12684              
+ Misses        959      956       -3     
  Partials      245      245              
Impacted Files Coverage Δ
service/collector.go 76.31% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten

Copy link
Copy Markdown
Contributor

The fix for the following is now on main, maybe we just need to stay on main until the next release.

# github.com/jaegertracing/jaeger/cmd/collector/app/handler
Error: /home/runner/go/pkg/mod/github.com/jaegertracing/jaeger@v1.39.0/cmd/collector/app/handler/otlp_receiver.go:69:14: undefined: config.Receiver
Error: /home/runner/go/pkg/mod/github.com/jaegertracing/jaeger@v1.39.0/cmd/collector/app/handler/otlp_receiver.go:184:56: undefined: config.Type
Error: /home/runner/go/pkg/mod/github.com/jaegertracing/jaeger@v1.39.0/cmd/collector/app/handler/otlp_receiver.go:188:45: undefined: config.ComponentID
Error: /home/runner/go/pkg/mod/github.com/jaegertracing/jaeger@v1.39.0/cmd/collector/app/handler/otlp_receiver.go:192:44: undefined: config.DataType
Error: /home/runner/go/pkg/mod/github.com/jaegertracing/jaeger@v1.39.0/cmd/collector/app/handler/otlp_receiver.go:192:64: undefined: config.ComponentID
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/internal/components [build failed]

codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Nov 14, 2022
Moving dependency to version in main to move open-telemetry/opentelemetry-collector#6511 in core forward.
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Nov 14, 2022
Moving dependency to version in main to move open-telemetry/opentelemetry-collector#6511 in core forward.
Signed-off-by: Bogdan <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit bd1165e into open-telemetry:main Nov 14, 2022
@bogdandrutu bogdandrutu deleted the rmdepconfig branch November 14, 2022 21:03
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
Moving dependency to version in main to move open-telemetry/opentelemetry-collector#6511 in core forward.
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
Moving dependency to version in main to move open-telemetry/opentelemetry-collector#6511 in core forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants