Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pdata Clone methods in favor of CopyTo #6164

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

dmitryax
Copy link
Member

Resolves #6154

@dmitryax dmitryax requested review from a team and mx-psi September 27, 2022 22:47
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 91.76% // Head: 91.77% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (996f9bd) compared to base (380f1b1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6164   +/-   ##
=======================================
  Coverage   91.76%   91.77%           
=======================================
  Files         218      218           
  Lines       13352    13358    +6     
=======================================
+ Hits        12253    12259    +6     
  Misses        870      870           
  Partials      229      229           
Impacted Files Coverage Δ
pdata/plog/logs.go 96.55% <100.00%> (+0.25%) ⬆️
pdata/pmetric/metrics.go 75.45% <100.00%> (+0.45%) ⬆️
pdata/ptrace/traces.go 81.81% <100.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be some usages of these funcs?

Fine to do it in the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Clone vs CopyTo usage
2 participants