Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MetricDataType with MetricType #6127

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

bogdandrutu
Copy link
Member

  • Dreprecate old APIs, add new APIs without "Data"

Updates #6081

Signed-off-by: Bogdan [email protected]

@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 September 20, 2022 17:49
* Dreprecate old APIs, add new APIs without "Data"

Updates open-telemetry#6081

Signed-off-by: Bogdan <[email protected]>
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 91.95% // Head: 91.94% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (47247be) compared to base (a9b5a1d).
Patch coverage: 96.07% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6127      +/-   ##
==========================================
- Coverage   91.95%   91.94%   -0.02%     
==========================================
  Files         217      217              
  Lines       13319    13321       +2     
==========================================
  Hits        12248    12248              
- Misses        842      844       +2     
  Partials      229      229              
Impacted Files Coverage Δ
pdata/pmetric/metrics.go 88.04% <86.66%> (-1.96%) ⬇️
...er/loggingexporter/internal/otlptext/databuffer.go 99.12% <100.00%> (ø)
pdata/pmetric/generated_metrics.go 96.09% <100.00%> (ø)
processor/batchprocessor/splitmetrics.go 98.63% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit 937d1e6 into open-telemetry:main Sep 21, 2022
@bogdandrutu bogdandrutu deleted the metricdata branch October 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants