-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move extension/storage to extension/experimental/storage #4082
Move extension/storage to extension/experimental/storage #4082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good here, please make sure to update the contrib repo as well.
Co-authored-by: Anthony Mirabella <[email protected]>
…ntal-storageextension
@codeboten @Aneurysm9 see comment in the issue, do we follow the same pattern for just interfaces? |
Which pattern? Having |
Was referring to the suffix since it is not an extension itself |
@bogdandrutu storageextension suffix has been removed to storage. Thank you. |
Codecov Report
@@ Coverage Diff @@
## main #4082 +/- ##
==========================================
+ Coverage 87.53% 87.87% +0.34%
==========================================
Files 173 173
Lines 10211 10181 -30
==========================================
+ Hits 8938 8947 +9
+ Misses 1010 984 -26
+ Partials 263 250 -13
Continue to review full report at Codecov.
|
Hi @bogdandrutu can you please do a final review and merge? ty! |
@JamesJHPark please make sure that the contrib is fixed if needed. |
Description:
This PR is to move the experimental package
extension/storage
toextension/experimental/storage
and follow the extension packages naming conventions.Link to tracking Issue:
#4059