[exporterhelper] Use configoptional for storage field#15184
[exporterhelper] Use configoptional for storage field#15184evan-bradley wants to merge 9 commits into
storage field#15184Conversation
…tional (open-telemetry#13376)" This reverts commit 1ebb9b2.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (75.60%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15184 +/- ##
==========================================
+ Coverage 90.38% 91.26% +0.88%
==========================================
Files 702 704 +2
Lines 54097 45345 -8752
==========================================
- Hits 48893 41384 -7509
+ Misses 4054 2805 -1249
- Partials 1150 1156 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 32.55%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | BenchmarkPersistentQueue |
148.8 µs | 205.7 µs | -27.67% |
| ❌ | BenchmarkMemoryQueueWaitForResult |
48 µs | 71.2 µs | -32.55% |
| ⚡ | BenchmarkBatchMetricProcessor2k |
186.2 ms | 126.4 ms | +47.28% |
| ❌ | BenchmarkHTTPProtoLogsSequential |
3.7 ms | 5.1 ms | -28.01% |
| ❌ | BenchmarkGRPCLogsSequential |
4.5 ms | 6.3 ms | -28.17% |
Comparing evan-bradley:exporterhelper-optional (5295580) with main (98f555d)
Footnotes
-
76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
Shows a concrete implementation of #15175 by layering on top of the changes in that PR. Please pay attention specifically to the changes under
exporter/exporterhelper, the rest will be removed after #15175 is merged.