Skip to content

[exporterhelper] Use configoptional for storage field#15184

Draft
evan-bradley wants to merge 9 commits into
open-telemetry:mainfrom
evan-bradley:exporterhelper-optional
Draft

[exporterhelper] Use configoptional for storage field#15184
evan-bradley wants to merge 9 commits into
open-telemetry:mainfrom
evan-bradley:exporterhelper-optional

Conversation

@evan-bradley
Copy link
Copy Markdown
Contributor

Description

Shows a concrete implementation of #15175 by layering on top of the changes in that PR. Please pay attention specifically to the changes under exporter/exporterhelper, the rest will be removed after #15175 is merged.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 75.60976% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.26%. Comparing base (98f555d) to head (5295580).
⚠️ Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
confmap/xconfmap/scalarunmarshaler.go 73.80% 6 Missing and 5 partials ⚠️
confmap/internal/marshaloption.go 0.00% 6 Missing ⚠️
confmap/internal/unmarshaloption.go 0.00% 6 Missing ⚠️
config/configoptional/optional.go 87.50% 1 Missing and 2 partials ⚠️
confmap/internal/encoder.go 75.00% 1 Missing and 1 partial ⚠️
confmap/xconfmap/scalarmarshaler.go 88.88% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (75.60%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15184      +/-   ##
==========================================
+ Coverage   90.38%   91.26%   +0.88%     
==========================================
  Files         702      704       +2     
  Lines       54097    45345    -8752     
==========================================
- Hits        48893    41384    -7509     
+ Misses       4054     2805    -1249     
- Partials     1150     1156       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 23, 2026

Merging this PR will degrade performance by 32.55%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 4 regressed benchmarks
✅ 2 untouched benchmarks
⏩ 76 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkPersistentQueue 148.8 µs 205.7 µs -27.67%
BenchmarkMemoryQueueWaitForResult 48 µs 71.2 µs -32.55%
BenchmarkBatchMetricProcessor2k 186.2 ms 126.4 ms +47.28%
BenchmarkHTTPProtoLogsSequential 3.7 ms 5.1 ms -28.01%
BenchmarkGRPCLogsSequential 4.5 ms 6.3 ms -28.17%

Comparing evan-bradley:exporterhelper-optional (5295580) with main (98f555d)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added Stale and removed Stale labels May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant