[mdatagen] Make display name required in metadata.yaml#15105
Conversation
Merging this PR will improve performance by 27.66%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | BenchmarkTraceSizeSpanCount |
60 ns | 47 ns | +27.66% |
Comparing jaydeluca:make-display-required (12db8e5) with main (28265fc)
Footnotes
-
76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
failing contrib tests show that i missed a few internal components in my pass on contrib, so I will put this into draft and address those first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15105 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 699 699
Lines 44766 44762 -4
=======================================
- Hits 40855 40853 -2
+ Misses 2769 2768 -1
+ Partials 1142 1141 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
will re-open this when i finish unblocking it |
The
display_nameattribute was added in #14115, and I have since gone through and added display names to all core and contrib components.@mx-psi raised the idea that we could switch this field from optional to required to now ensure all modules going forward include this.