Skip to content

[mdatagen] Make display name required in metadata.yaml#15105

Closed
jaydeluca wants to merge 2 commits into
open-telemetry:mainfrom
jaydeluca:make-display-required
Closed

[mdatagen] Make display name required in metadata.yaml#15105
jaydeluca wants to merge 2 commits into
open-telemetry:mainfrom
jaydeluca:make-display-required

Conversation

@jaydeluca
Copy link
Copy Markdown
Member

The display_name attribute was added in #14115, and I have since gone through and added display names to all core and contrib components.

@mx-psi raised the idea that we could switch this field from optional to required to now ensure all modules going forward include this.

@jaydeluca jaydeluca requested review from a team and dmitryax as code owners April 13, 2026 16:34
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 13, 2026

Merging this PR will improve performance by 27.66%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 6 untouched benchmarks
⏩ 76 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkTraceSizeSpanCount 60 ns 47 ns +27.66%

Comparing jaydeluca:make-display-required (12db8e5) with main (28265fc)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@jaydeluca
Copy link
Copy Markdown
Member Author

failing contrib tests show that i missed a few internal components in my pass on contrib, so I will put this into draft and address those first

@jaydeluca jaydeluca marked this pull request as draft April 13, 2026 16:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.26%. Comparing base (67a8d34) to head (12db8e5).
⚠️ Report is 57 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15105   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         699      699           
  Lines       44766    44762    -4     
=======================================
- Hits        40855    40853    -2     
+ Misses       2769     2768    -1     
+ Partials     1142     1141    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Apr 28, 2026
@jaydeluca
Copy link
Copy Markdown
Member Author

will re-open this when i finish unblocking it

@jaydeluca jaydeluca closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant