Skip to content

Add support for otelconf v1#14792

Closed
dmathieu wants to merge 7 commits intoopen-telemetry:mainfrom
dmathieu:upgrade-otelconf
Closed

Add support for otelconf v1#14792
dmathieu wants to merge 7 commits intoopen-telemetry:mainfrom
dmathieu:upgrade-otelconf

Conversation

@dmathieu
Copy link
Copy Markdown
Member

@dmathieu dmathieu commented Mar 18, 2026

This adds support for the stable/v1 version of otelconf, with a migration from v0.3.0 to v1 similar to what was done for v0.2 to v0.3.


// The regular expression for valid config field tag.
var configFieldTagRegExp = regexp.MustCompile("^[a-z0-9][a-z0-9_]*$")
var configFieldTagRegExp = regexp.MustCompile("^[a-z0-9][a-z0-9_/]*$")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be required if we can manage to get the experimental functionality into otelconf/x as per open-telemetry/opentelemetry-go-contrib#8529

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 35.71429% with 171 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.03%. Comparing base (ec18380) to head (bb1f171).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...try/otelconftelemetry/internal/migration/v0.3.0.go 11.83% 146 Missing and 3 partials ⚠️
...lemetry/otelconftelemetry/internal/migration/v1.go 48.78% 19 Missing and 2 partials ⚠️
service/internal/promtest/server_util.go 90.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (35.71%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14792      +/-   ##
==========================================
- Coverage   91.39%   91.03%   -0.37%     
==========================================
  Files         695      696       +1     
  Lines       44400    44609     +209     
==========================================
+ Hits        40581    40609      +28     
- Misses       2686     2858     +172     
- Partials     1133     1142       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread service/telemetry/otelconftelemetry/internal/migration/v0.3.0.go
Comment thread service/telemetry/otelconftelemetry/internal/migration/v0.3.0.go
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 18, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks
⏩ 76 skipped benchmarks1


Comparing dmathieu:upgrade-otelconf (c643364) with main (95b4d69)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Apr 8, 2026
@dmathieu
Copy link
Copy Markdown
Member Author

dmathieu commented Apr 8, 2026

Closing this. I naively assumed it would be easier. We need to do some prep work and deprecations before we can do this upgrade.

@dmathieu dmathieu closed this Apr 8, 2026
@dmathieu dmathieu deleted the upgrade-otelconf branch April 8, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants