Add support for otelconf v1#14792
Conversation
0638600 to
fa957d7
Compare
|
|
||
| // The regular expression for valid config field tag. | ||
| var configFieldTagRegExp = regexp.MustCompile("^[a-z0-9][a-z0-9_]*$") | ||
| var configFieldTagRegExp = regexp.MustCompile("^[a-z0-9][a-z0-9_/]*$") |
There was a problem hiding this comment.
This change is required, as TracerConfiguratorDevelopment includes a / in its tag.
https://github.com/open-telemetry/opentelemetry-go-contrib/blob/590c561a7efe36cb3ceff70d199be38af8e647a9/otelconf/generated_config.go#L2254C2-L2254C31
There was a problem hiding this comment.
This won't be required if we can manage to get the experimental functionality into otelconf/x as per open-telemetry/opentelemetry-go-contrib#8529
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (35.71%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14792 +/- ##
==========================================
- Coverage 91.39% 91.03% -0.37%
==========================================
Files 695 696 +1
Lines 44400 44609 +209
==========================================
+ Hits 40581 40609 +28
- Misses 2686 2858 +172
- Partials 1133 1142 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Israel Blancas <iblancasa@gmail.com>
Co-authored-by: Israel Blancas <iblancasa@gmail.com>
This reverts commit 8a5f8e3.
Merging this PR will not alter performance
|
776b9c1 to
c643364
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closing this. I naively assumed it would be easier. We need to do some prep work and deprecations before we can do this upgrade. |
This adds support for the stable/v1 version of otelconf, with a migration from v0.3.0 to v1 similar to what was done for v0.2 to v0.3.