[cmd/mdatagen] Do not generate redundant reaggregation config options by dmitryax · Pull Request #14689 · open-telemetry/opentelemetry-collector

dmitryax · 2026-03-04T03:41:20Z

Do not generate the following metrics re-aggregation config options for metrics that don't have any attributes that can be aggregated:

attributes
aggregation_strategy

codecov · 2026-03-04T03:53:14Z

Codecov Report

❌ Patch coverage is 77.58621% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.92%. Comparing base (e2ff1ad) to head (7384a2b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...pleconnector/internal/metadata/generated_config.go	78.78%	4 Missing and 3 partials ⚠️
...amplescraper/internal/metadata/generated_config.go	79.41%	4 Missing and 3 partials ⚠️
cmd/mdatagen/internal/command.go	0.00%	6 Missing ⚠️
...mplereceiver/internal/metadata/generated_config.go	84.21%	3 Missing and 3 partials ⚠️

❌ Your patch status has failed because the patch coverage (77.58%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14689      +/-   ##
==========================================
+ Coverage   91.83%   91.92%   +0.09%     
==========================================
  Files         685      685              
  Lines       43391    43244     -147     
==========================================
- Hits        39846    39751      -95     
+ Misses       2465     2419      -46     
+ Partials     1080     1074       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dmitryax · 2026-03-04T20:04:55Z

#14703 to fix unrelated changelog failure

Do not generate the following metrics re-aggregation config options for metrics that don't have any attributes that can be aggregated: - `attributes` - `aggregation_strategy`

Follow-up to open-telemetry#14689. When reaggregation_enabled: true, instead of a shared MetricConfig for all metrics, each metric now gets its own generated <MetricName>Config type containing only the fields relevant to it: - All metrics: Enabled - Metrics with aggregatable attributes: additionally `AggregationStrategy` and `EnabledAttributes []<MetricName>AttributeKey` EnabledAttributes is typed as `[]<MetricName>AttributeKey` rather than `[]string`, with a generated enum constant per attribute (e.g. DefaultMetricAttributeKeyStringAttr). This makes the API type-safe and self-documenting, and eliminates the runtime definedAttributes/requiredAttributes slice allocations that were previously needed for validation. `Validate()` is generated per-metric with the valid attribute set and required attributes hardcoded, producing descriptive errors: - metric default.metric doesn't have an attribute X, valid attributes: [...] - required_string_attr is a required attribute for reaggregate.metric.with_required metric and must be included - invalid aggregation strategy "X", valid strategies: [sum, avg, min, max] Breaking change: Components using `reaggregation_enabled: true` will need to update references from MetricConfig to their per-metric <MetricName>Config type.

…ocessortest to v0.148.0 (#40) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [go.opentelemetry.io/collector/processor/processortest](https://github.com/open-telemetry/opentelemetry-collector) | `v0.147.0` → `v0.148.0` | ![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fcollector%2fprocessor%2fprocessortest/v0.148.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fcollector%2fprocessor%2fprocessortest/v0.147.0/v0.148.0?slim=true) | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/processor/processortest)</summary> ### [`v0.148.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1540v01480) [Compare Source](open-telemetry/opentelemetry-collector@v0.147.0...v0.148.0) ##### ❗ Known Issues ❗ - `service`: The collector's internal Prometheus metrics endpoint (`:8888`) now emits OTel service labels with underscore names (`service_name`, `service_instance_id`, `service_version`) instead of dot-notation names (`service.name`, `service.instance.id`, `service.version`). Users scraping this endpoint with the Prometheus receiver will see these renamed labels in resource and datapoint attributes. As a workaround, add the following `metric_relabel_configs` to your scrape config in prometheus receiver: ```yaml metric_relabel_configs: - source_labels: [service_name] target_label: service.name - source_labels: [service_instance_id] target_label: service.instance.id - source_labels: [service_version] target_label: service.version - regex: service_name|service_instance_id|service_version action: labeldrop ``` See [#14814](open-telemetry/opentelemetry-collector#14814) for details and updates. ##### 🛑 Breaking changes 🛑 - `all`: Change metric units to be singular to match OTel specification, e.g. `{requests}` -> `{request}` ([#14753](open-telemetry/opentelemetry-collector#14753)) ##### 💡 Enhancements 💡 - `cmd/mdatagen`: Add deprecated\_type field to allow specifying an alias for component types. ([#14718](open-telemetry/opentelemetry-collector#14718)) - `cmd/mdatagen`: Generate entity-scoped MetricsBuilder API that enforces entity-metric associations at compile time ([#14659](open-telemetry/opentelemetry-collector#14659)) - `cmd/mdatagen`: Skip generating reaggregation config options for metrics that have no aggregatable attributes. ([#14689](open-telemetry/opentelemetry-collector#14689)) - `pkg/service`: The internal status reporter no longer drops repeated Ok and RecoverableError statuses ([#14282](open-telemetry/opentelemetry-collector#14282)) Status events can now carry metadata and there's value in allowing them to be emitted despite the status value itself not changing. ##### 🧰 Bug fixes 🧰 - `cmd/builder`: Add `.exe` to output binary names when building for Windows targets. ([#12591](open-telemetry/opentelemetry-collector#12591)) - `exporter/debug`: Add printing of metric metadata in detailed verbosity. ([#14667](open-telemetry/opentelemetry-collector#14667)) - `exporter/otlp_grpc`: Prevent nil pointer panic when push methods are called before the OTLP exporter initializes its gRPC clients. ([#14663](open-telemetry/opentelemetry-collector#14663)) When the sending queue and retry are disabled, calling ConsumeTraces, ConsumeMetrics, ConsumeLogs, or ConsumeProfiles before the OTLP exporter initializes its gRPC clients could cause a nil pointer dereference panic. The push methods now return an error instead of panicking. - `exporter/otlp_http`: Show the actual destination URL in error messages when request URL is modified by middleware. ([#14673](open-telemetry/opentelemetry-collector#14673)) Unwraps the `*url.Error` returned by `http.Client.Do()` to prevent misleading error logs when a middleware extension dynamically updates the endpoint. - `pdata/pprofile`: Switch the dictionary of dictionary tables entries only once when merging profiles ([#14709](open-telemetry/opentelemetry-collector#14709)) For dictionary table data, we used to switch their dictionaries when doing the switch for the data that uses them. However, when an entry is associated with multiple other data (several samples can use the same stack), we would have been switching the dictionaries of the entry multiple times. We now switch dictionaries for dictionary table data only once, before switching the resource profiles.  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.t000-n.de/t.behrendt/tracebasedlogsampler/pulls/40 Reviewed-by: t.behrendt <t.behrendt@noreply.localhost> Co-authored-by: Renovate Bot <renovate@t00n.de> Co-committed-by: Renovate Bot <renovate@t00n.de>

…1.54.0 (#33) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [go.opentelemetry.io/collector/confmap](https://github.com/open-telemetry/opentelemetry-collector) | `v1.50.0` → `v1.54.0` | ![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fcollector%2fconfmap/v1.54.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fcollector%2fconfmap/v1.50.0/v1.54.0?slim=true) | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/confmap)</summary> ### [`v1.54.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1540v01480) ##### ❗ Known Issues ❗ - `service`: The collector's internal Prometheus metrics endpoint (`:8888`) now emits OTel service labels with underscore names (`service_name`, `service_instance_id`, `service_version`) instead of dot-notation names (`service.name`, `service.instance.id`, `service.version`). Users scraping this endpoint with the Prometheus receiver will see these renamed labels in resource and datapoint attributes. As a workaround, add the following `metric_relabel_configs` to your scrape config in prometheus receiver: ```yaml metric_relabel_configs: - source_labels: [service_name] target_label: service.name - source_labels: [service_instance_id] target_label: service.instance.id - source_labels: [service_version] target_label: service.version - regex: service_name|service_instance_id|service_version action: labeldrop ``` See [#14814](open-telemetry/opentelemetry-collector#14814) for details and updates. ##### 🛑 Breaking changes 🛑 - `all`: Change metric units to be singular to match OTel specification, e.g. `{requests}` -> `{request}` ([#14753](open-telemetry/opentelemetry-collector#14753)) ##### 💡 Enhancements 💡 - `cmd/mdatagen`: Add deprecated\_type field to allow specifying an alias for component types. ([#14718](open-telemetry/opentelemetry-collector#14718)) - `cmd/mdatagen`: Generate entity-scoped MetricsBuilder API that enforces entity-metric associations at compile time ([#14659](open-telemetry/opentelemetry-collector#14659)) - `cmd/mdatagen`: Skip generating reaggregation config options for metrics that have no aggregatable attributes. ([#14689](open-telemetry/opentelemetry-collector#14689)) - `pkg/service`: The internal status reporter no longer drops repeated Ok and RecoverableError statuses ([#14282](open-telemetry/opentelemetry-collector#14282)) Status events can now carry metadata and there's value in allowing them to be emitted despite the status value itself not changing. ##### 🧰 Bug fixes 🧰 - `cmd/builder`: Add `.exe` to output binary names when building for Windows targets. ([#12591](open-telemetry/opentelemetry-collector#12591)) - `exporter/debug`: Add printing of metric metadata in detailed verbosity. ([#14667](open-telemetry/opentelemetry-collector#14667)) - `exporter/otlp_grpc`: Prevent nil pointer panic when push methods are called before the OTLP exporter initializes its gRPC clients. ([#14663](open-telemetry/opentelemetry-collector#14663)) When the sending queue and retry are disabled, calling ConsumeTraces, ConsumeMetrics, ConsumeLogs, or ConsumeProfiles before the OTLP exporter initializes its gRPC clients could cause a nil pointer dereference panic. The push methods now return an error instead of panicking. - `exporter/otlp_http`: Show the actual destination URL in error messages when request URL is modified by middleware. ([#14673](open-telemetry/opentelemetry-collector#14673)) Unwraps the `*url.Error` returned by `http.Client.Do()` to prevent misleading error logs when a middleware extension dynamically updates the endpoint. - `pdata/pprofile`: Switch the dictionary of dictionary tables entries only once when merging profiles ([#14709](open-telemetry/opentelemetry-collector#14709)) For dictionary table data, we used to switch their dictionaries when doing the switch for the data that uses them. However, when an entry is associated with multiple other data (several samples can use the same stack), we would have been switching the dictionaries of the entry multiple times. We now switch dictionaries for dictionary table data only once, before switching the resource profiles.  ### [`v1.53.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1530v01470) ##### 💡 Enhancements 💡 - `exporter/debug`: Output bucket counts for exponential histogram data points in normal verbosity. ([#10463](open-telemetry/opentelemetry-collector#10463)) - `pkg/exporterhelper`: Add `metadata_keys` configuration to `sending_queue.batch.partition` to partition batches by client metadata ([#14139](open-telemetry/opentelemetry-collector#14139)) The `metadata_keys` configuration option is now available in the `sending_queue.batch.partition` section for all exporters. When specified, batches are partitioned based on the values of the listed metadata keys, allowing separate batching per metadata partition. This feature is automatically configured when using `exporterhelper.WithQueue()`. ##### 🧰 Bug fixes 🧰 - `cmd/builder`: Fix duplicate error output when CLI command execution fails in the builder tool. ([#14436](open-telemetry/opentelemetry-collector#14436)) - `cmd/mdatagen`: Fix duplicate error output when CLI command execution fails in the mdatagen tool. ([#14436](open-telemetry/opentelemetry-collector#14436)) - `cmd/mdatagen`: Fix semconv URL validation for metrics with underscores in their names ([#14583](open-telemetry/opentelemetry-collector#14583)) Metrics like `system.disk.io_time` now correctly validate against semantic convention URLs containing underscores in the anchor tag. - `extension/memory_limiter`: Use ChainUnaryInterceptor instead of UnaryInterceptor to allow multiple interceptors. ([#14634](open-telemetry/opentelemetry-collector#14634)) If multiple extensions that use the UnaryInterceptor are set the binary panics at start time. - `extension/memory_limiter`: Add support for streaming services. ([#14634](open-telemetry/opentelemetry-collector#14634)) - `pkg/config/configmiddleware`: Add context.Context to HTTP middleware interface constructors. ([#14523](open-telemetry/opentelemetry-collector#14523)) This is a breaking API change for components that implement or use extensionmiddleware. - `pkg/confmap`: Fix another issue where configs could fail to decode when using interpolated values in string fields. ([#14034](open-telemetry/opentelemetry-collector#14034)) For example, a resource attribute can be set via an environment variable to a string that is parseable as a number, e.g. `1234`. (A similar bug was fixed in a previous release: that one was triggered when the field was nested in a struct, whereas this one is triggered when the field internally has type "pointer to string" rather than "string".) - `pkg/otelcol`: The featuregate subcommand now rejects extra positional arguments instead of silently ignoring them. ([#14554](open-telemetry/opentelemetry-collector#14554)) - `pkg/queuebatch`: Fix data race in partition\_batcher where resetTimer() was called outside mutex, causing concurrent timer.Reset() calls and unpredictable batch flush timing under load. ([#14491](open-telemetry/opentelemetry-collector#14491)) - `pkg/scraperhelper`: Log scrapers now emit log-appropriate receiver telemetry ([#14654](open-telemetry/opentelemetry-collector#14654)) Log scrapers previously emitted the same receiver telemetry as metric scrapers, such as the otelcol\_receiver\_accepted\_metric\_points metric (instead of otelcol\_receiver\_accepted\_log\_records), or spans named receiver/myreceiver/MetricsReceived (instead of receiver/myreceiver/LogsReceived). This did not affect scraper-specific spans and metrics. - `processor/batch`: Fixes a bug where the batch processor would not copy `SchemaUrl` metadata from resource and scope containers during partial batch splits. ([#12279](open-telemetry/opentelemetry-collector#12279), [#14620](open-telemetry/opentelemetry-collector#14620))  ### [`v1.52.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1520v01461)  ### [`v1.51.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1510v01450) ##### 💡 Enhancements 💡 - `pkg/scraperhelper`: ScraperID has been added to the logs for metrics, logs, and profiles ([#14461](open-telemetry/opentelemetry-collector#14461)) ##### 🧰 Bug fixes 🧰 - `exporter/otlp_grpc`: Fix the OTLP exporter balancer to use round\_robin by default, as intended. ([#14090](open-telemetry/opentelemetry-collector#14090)) - `pkg/config/configoptional`: Fix `Unmarshal` methods not being called when config is wrapped inside `Optional` ([#14500](open-telemetry/opentelemetry-collector#14500)) This bug notably manifested in the fact that the `sending_queue::batch::sizer` config for exporters stopped defaulting to `sending_queue::sizer`, which sometimes caused the wrong units to be used when configuring `sending_queue::batch::min_size` and `max_size`. As part of the fix, `xconfmap` exposes a new `xconfmap.WithForceUnmarshaler` option, to be used in the `Unmarshal` methods of wrapper types like `configoptional.Optional` to make sure the `Unmarshal` method of the inner type is called. The default behavior remains that calling `conf.Unmarshal` on the `confmap.Conf` passed as argument to an `Unmarshal` method will skip any top-level `Unmarshal` methods to avoid infinite recursion in standard use cases. - `pkg/confmap`: Fix an issue where configs could fail to decode when using interpolated values in string fields. ([#14413](open-telemetry/opentelemetry-collector#14413)) For example, a header can be set via an environment variable to a string that is parseable as a number, e.g. `1234` - `pkg/service`: Don't error on startup when process metrics are enabled on unsupported OSes (e.g. AIX) ([#14307](open-telemetry/opentelemetry-collector#14307))  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.t000-n.de/t.behrendt/tracebasedlogsampler/pulls/33 Reviewed-by: t.behrendt <t.behrendt@noreply.localhost> Co-authored-by: Renovate Bot <renovate@t00n.de> Co-committed-by: Renovate Bot <renovate@t00n.de>

dmitryax requested a review from a team as a code owner March 4, 2026 03:41

dmitryax requested a review from mx-psi March 4, 2026 03:41

dmitryax force-pushed the not-generate-agg-config-option branch from 10f0ae2 to 2faf4a4 Compare March 4, 2026 03:44

dmitryax force-pushed the not-generate-agg-config-option branch from 2faf4a4 to 4317012 Compare March 4, 2026 04:06

github-actions Bot added the cmd/mdatagen label Mar 4, 2026

dmitryax force-pushed the not-generate-agg-config-option branch from 4317012 to 510459b Compare March 4, 2026 04:08

mx-psi approved these changes Mar 4, 2026

View reviewed changes

dmitryax force-pushed the not-generate-agg-config-option branch from 510459b to 84334d9 Compare March 4, 2026 19:49

dmitryax force-pushed the not-generate-agg-config-option branch 2 times, most recently from 97e1e71 to 5cd2eee Compare March 5, 2026 00:28

[cmd/mdatagen] Do not generate redundant reaggregation config options

7384a2b

Do not generate the following metrics re-aggregation config options for metrics that don't have any attributes that can be aggregated: - `attributes` - `aggregation_strategy`

dmitryax force-pushed the not-generate-agg-config-option branch from 5cd2eee to 7384a2b Compare March 5, 2026 02:00

dmitryax enabled auto-merge March 5, 2026 02:36

dmitryax added this pull request to the merge queue Mar 5, 2026

Merged via the queue into open-telemetry:main with commit 92d7303 Mar 5, 2026
83 of 88 checks passed

dmitryax deleted the not-generate-agg-config-option branch March 5, 2026 02:58

dloucasfx mentioned this pull request Mar 24, 2026

[chore] Changelog for v0.148.0 signalfx/splunk-otel-collector#7357

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cmd/mdatagen] Do not generate redundant reaggregation config options#14689

[cmd/mdatagen] Do not generate redundant reaggregation config options#14689
dmitryax merged 1 commit into
open-telemetry:mainfrom
dmitryax:not-generate-agg-config-option

dmitryax commented Mar 4, 2026

Uh oh!

codecov Bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

dmitryax commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dmitryax commented Mar 4, 2026

Uh oh!

codecov Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dmitryax commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Mar 4, 2026 •

edited

Loading