Skip to content

Add new experimental toStringMapRaw method to xconfmap#14480

Merged
mx-psi merged 9 commits into
open-telemetry:mainfrom
theomagellan:add-tostringmapraw-xconfmap
Feb 9, 2026
Merged

Add new experimental toStringMapRaw method to xconfmap#14480
mx-psi merged 9 commits into
open-telemetry:mainfrom
theomagellan:add-tostringmapraw-xconfmap

Conversation

@theomagellan
Copy link
Copy Markdown
Contributor

Description

This experimental method allows for stringmap manipulations without destroying internal types like ExpandedValue.
Destroying these internal values could lead to unrecoverable errors like having an env var fully numeric but expected as string. Using ToStringMap would permanently flatten the ExpandedValue into its Value type regardless of intent.

Testing

Added tests.

@theomagellan theomagellan force-pushed the add-tostringmapraw-xconfmap branch from 33b973d to 44dc1cc Compare January 26, 2026 19:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.84%. Comparing base (88735a1) to head (5a03f60).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
confmap/xconfmap/confmap.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14480      +/-   ##
==========================================
- Coverage   91.86%   91.84%   -0.02%     
==========================================
  Files         677      678       +1     
  Lines       42705    42723      +18     
==========================================
+ Hits        39229    39239      +10     
- Misses       2423     2429       +6     
- Partials     1053     1055       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 26, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing theomagellan:add-tostringmapraw-xconfmap (5a03f60) with main (5e3bf40)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 61 untouched benchmarks
⏩ 20 skipped benchmarks1

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@theomagellan theomagellan marked this pull request as ready for review January 26, 2026 20:43
@theomagellan theomagellan requested review from a team, evan-bradley and mx-psi as code owners January 26, 2026 20:43
Comment thread .chloggen/add-tostringmapraw-xconfmap.yaml Outdated
Comment thread .chloggen/add-tostringmapraw-xconfmap.yaml Outdated
Comment thread confmap/xconfmap/confmap.go
Comment thread confmap/xconfmap/confmap.go
@theomagellan theomagellan requested a review from mx-psi February 4, 2026 09:19
@theomagellan theomagellan force-pushed the add-tostringmapraw-xconfmap branch from ab8757a to ef8dadb Compare February 4, 2026 10:10
@theomagellan theomagellan force-pushed the add-tostringmapraw-xconfmap branch from ef8dadb to 007542d Compare February 4, 2026 10:12
Comment thread confmap/xconfmap/confmap.go
Comment thread .chloggen/add-tostringmapraw-xconfmap.yaml Outdated
theomagellan and others added 2 commits February 4, 2026 16:12
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Feb 6, 2026

Will merge this on Monday unless there are further comments

@mx-psi mx-psi added this pull request to the merge queue Feb 9, 2026
Merged via the queue into open-telemetry:main with commit 53be17e Feb 9, 2026
61 of 62 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Feb 9, 2026

Thank you for your contribution @theomagellan! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

TimoBehrendt pushed a commit to TimoBehrendt/tracebasedlogsampler that referenced this pull request Mar 19, 2026
…ocessortest to v0.147.0 (#38)

This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [go.opentelemetry.io/collector/processor/processortest](https://github.com/open-telemetry/opentelemetry-collector) | `v0.144.0` → `v0.147.0` | ![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fcollector%2fprocessor%2fprocessortest/v0.147.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fcollector%2fprocessor%2fprocessortest/v0.144.0/v0.147.0?slim=true) |

---

### Release Notes

<details>
<summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/processor/processortest)</summary>

### [`v0.147.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1530v01470)

[Compare Source](open-telemetry/opentelemetry-collector@v0.146.1...v0.147.0)

##### 💡 Enhancements 💡

- `exporter/debug`: Output bucket counts for exponential histogram data points in normal verbosity. ([#&#8203;10463](open-telemetry/opentelemetry-collector#10463))
- `pkg/exporterhelper`: Add `metadata_keys` configuration to `sending_queue.batch.partition` to partition batches by client metadata ([#&#8203;14139](open-telemetry/opentelemetry-collector#14139))
  The `metadata_keys` configuration option is now available in the `sending_queue.batch.partition` section for all exporters.
  When specified, batches are partitioned based on the values of the listed metadata keys, allowing separate batching per metadata partition. This feature
  is automatically configured when using `exporterhelper.WithQueue()`.

##### 🧰 Bug fixes 🧰

- `cmd/builder`: Fix duplicate error output when CLI command execution fails in the builder tool. ([#&#8203;14436](open-telemetry/opentelemetry-collector#14436))

- `cmd/mdatagen`: Fix duplicate error output when CLI command execution fails in the mdatagen tool. ([#&#8203;14436](open-telemetry/opentelemetry-collector#14436))

- `cmd/mdatagen`: Fix semconv URL validation for metrics with underscores in their names ([#&#8203;14583](open-telemetry/opentelemetry-collector#14583))
  Metrics like `system.disk.io_time` now correctly validate against semantic convention URLs containing underscores in the anchor tag.

- `extension/memory_limiter`: Use ChainUnaryInterceptor instead of UnaryInterceptor to allow multiple interceptors. ([#&#8203;14634](open-telemetry/opentelemetry-collector#14634))
  If multiple extensions that use the UnaryInterceptor are set the binary panics at start time.

- `extension/memory_limiter`: Add support for streaming services. ([#&#8203;14634](open-telemetry/opentelemetry-collector#14634))

- `pkg/config/configmiddleware`: Add context.Context to HTTP middleware interface constructors. ([#&#8203;14523](open-telemetry/opentelemetry-collector#14523))
  This is a breaking API change for components that implement or use extensionmiddleware.

- `pkg/confmap`: Fix another issue where configs could fail to decode when using interpolated values in string fields. ([#&#8203;14034](open-telemetry/opentelemetry-collector#14034))
  For example, a resource attribute can be set via an environment variable to a string that is parseable as a number, e.g. `1234`.

  (A similar bug was fixed in a previous release: that one was triggered when the field was nested in a struct,
  whereas this one is triggered when the field internally has type "pointer to string" rather than "string".)

- `pkg/otelcol`: The featuregate subcommand now rejects extra positional arguments instead of silently ignoring them. ([#&#8203;14554](open-telemetry/opentelemetry-collector#14554))

- `pkg/queuebatch`: Fix data race in partition\_batcher where resetTimer() was called outside mutex, causing concurrent timer.Reset() calls and unpredictable batch flush timing under load. ([#&#8203;14491](open-telemetry/opentelemetry-collector#14491))

- `pkg/scraperhelper`: Log scrapers now emit log-appropriate receiver telemetry ([#&#8203;14654](open-telemetry/opentelemetry-collector#14654))
  Log scrapers previously emitted the same receiver telemetry as metric scrapers,
  such as the otelcol\_receiver\_accepted\_metric\_points metric (instead of otelcol\_receiver\_accepted\_log\_records),
  or spans named receiver/myreceiver/MetricsReceived (instead of receiver/myreceiver/LogsReceived).

  This did not affect scraper-specific spans and metrics.

- `processor/batch`: Fixes a bug where the batch processor would not copy `SchemaUrl` metadata from resource and scope containers during partial batch splits. ([#&#8203;12279](open-telemetry/opentelemetry-collector#12279), [#&#8203;14620](open-telemetry/opentelemetry-collector#14620))

<!-- previous-version -->

### [`v0.146.1`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1520v01461)

[Compare Source](open-telemetry/opentelemetry-collector@v0.146.0...v0.146.1)

<!-- previous-version -->

### [`v0.146.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v01460)

[Compare Source](open-telemetry/opentelemetry-collector@v0.145.0...v0.146.0)

##### 🛑 Breaking changes 🛑

- `all`: Increase minimum Go version to 1.25 ([#&#8203;14567](open-telemetry/opentelemetry-collector#14567))

##### 🚩 Deprecations 🚩

- `pdata/pprofile`: Declare removed aggregation elements as deprecated. ([#&#8203;14528](open-telemetry/opentelemetry-collector#14528))

##### 💡 Enhancements 💡

- `all`: Add detailed failure attributes to exporter send\_failed metrics at detailed telemetry level. ([#&#8203;13956](open-telemetry/opentelemetry-collector#13956))
  The `otelcol_exporter_send_failed_{spans,metric_points,log_records}` metrics now include
  failure attributes when telemetry level is Detailed: `error.type` (OpenTelemetry semantic convention
  describing the error class) and `error.permanent` (indicates if error is permanent/non-retryable).
  The `error.type` attribute captures gRPC status codes (e.g., "Unavailable", "ResourceExhausted"),
  standard Go context errors (e.g., "canceled", "deadline\_exceeded"),
  and collector-specific errors (e.g., "shutdown").
  This enables better alerting and debugging by providing standardized error classification.

- `cmd/builder`: Introduce new experimental `init` subcommand ([#&#8203;14530](open-telemetry/opentelemetry-collector#14530))
  The new `init` subcommand initializes a new custom collector

- `cmd/builder`: Add "telemetry" field to allow configuring telemetry providers ([#&#8203;14575](open-telemetry/opentelemetry-collector#14575))
  Most users should not need to use this, this field should only be set if you
  intend to provide your own OpenTelemetry SDK.

- `cmd/mdatagen`: Introduce additional metadata (the version since the deprecation started, and the deprecation reason) for deprecated metrics. ([#&#8203;14113](open-telemetry/opentelemetry-collector#14113))

- `cmd/mdatagen`: Add optional `relationships` field to entity schema in metadata.yaml ([#&#8203;14284](open-telemetry/opentelemetry-collector#14284))

- `exporter/debug`: Add `output_paths` configuration option to control output destination when `use_internal_logger` is false. ([#&#8203;10472](open-telemetry/opentelemetry-collector#10472))
  When `use_internal_logger` is set to `false`, the debug exporter now supports configuring the output destination via the `output_paths` option.
  This allows users to send debug exporter output to `stdout`, `stderr`, or a file path.
  The default value is `["stdout"]` to maintain backward compatibility.

- `pkg/confmap`: Add experimental `ToStringMapRaw` function to decode `confmap.Conf` into a string map without losing internal types ([#&#8203;14480](open-telemetry/opentelemetry-collector#14480))
  This method exposes the internal structure of a `confmap.Conf` which may change at any time without prior notice

##### 🧰 Bug fixes 🧰

- `cmd/mdatagen`: Reset aggDataPoints during metric init to avoid index out of range panic across emit cycles when reaggregation is enabled. ([#&#8203;14569](open-telemetry/opentelemetry-collector#14569))
- `cmd/mdatagen`: Fix panic when mdatagen is run without arguments. ([#&#8203;14506](open-telemetry/opentelemetry-collector#14506))
- `pdata/pprofile`: Fix off-by-one issue in dictionary lookups. ([#&#8203;14534](open-telemetry/opentelemetry-collector#14534))
- `pkg/config/confighttp`: Fix high cardinality span name from request method from confighttp server internal telemetry ([#&#8203;14516](open-telemetry/opentelemetry-collector#14516))
  Follow spec to bound request method cardinality.
- `pkg/otelcol`: Ignore component aliases in the `otelcol components` command ([#&#8203;14492](open-telemetry/opentelemetry-collector#14492))
- `pkg/otelcol`: Order providers and converters in alphabetical order in the `components` subcommand. ([#&#8203;14476](open-telemetry/opentelemetry-collector#14476))

<!-- previous-version -->

### [`v0.145.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1510v01450)

[Compare Source](open-telemetry/opentelemetry-collector@v0.144.0...v0.145.0)

##### 💡 Enhancements 💡

- `pkg/scraperhelper`: ScraperID has been added to the logs for metrics, logs, and profiles ([#&#8203;14461](open-telemetry/opentelemetry-collector#14461))

##### 🧰 Bug fixes 🧰

- `exporter/otlp_grpc`: Fix the OTLP exporter balancer to use round\_robin by default, as intended. ([#&#8203;14090](open-telemetry/opentelemetry-collector#14090))

- `pkg/config/configoptional`: Fix `Unmarshal` methods not being called when config is wrapped inside `Optional` ([#&#8203;14500](open-telemetry/opentelemetry-collector#14500))
  This bug notably manifested in the fact that the `sending_queue::batch::sizer` config for exporters
  stopped defaulting to `sending_queue::sizer`, which sometimes caused the wrong units to be used
  when configuring `sending_queue::batch::min_size` and `max_size`.

  As part of the fix, `xconfmap` exposes a new `xconfmap.WithForceUnmarshaler` option, to be used in the `Unmarshal` methods
  of wrapper types like `configoptional.Optional` to make sure the `Unmarshal` method of the inner type is called.

  The default behavior remains that calling `conf.Unmarshal` on the `confmap.Conf` passed as argument to an `Unmarshal`
  method will skip any top-level `Unmarshal` methods to avoid infinite recursion in standard use cases.

- `pkg/confmap`: Fix an issue where configs could fail to decode when using interpolated values in string fields. ([#&#8203;14413](open-telemetry/opentelemetry-collector#14413))
  For example, a header can be set via an environment variable to a string that is parseable as a number, e.g. `1234`

- `pkg/service`: Don't error on startup when process metrics are enabled on unsupported OSes (e.g. AIX) ([#&#8203;14307](open-telemetry/opentelemetry-collector#14307))

<!-- previous-version -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My41LjQiLCJ1cGRhdGVkSW5WZXIiOiI0My41LjQiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->

Reviewed-on: https://gitea.t000-n.de/t.behrendt/tracebasedlogsampler/pulls/38
Reviewed-by: t.behrendt <t.behrendt@noreply.localhost>
Co-authored-by: Renovate Bot <renovate@t00n.de>
Co-committed-by: Renovate Bot <renovate@t00n.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants