support otlp_grpc alias for otlp exporter#14165
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14165 +/- ##
==========================================
- Coverage 92.15% 92.11% -0.05%
==========================================
Files 666 668 +2
Lines 41441 41389 -52
==========================================
- Hits 38191 38124 -67
- Misses 2213 2227 +14
- Partials 1037 1038 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- via claude support at more test to cover all lines
|
Hey @codeboten , happy to get your review, based on your feedback, I will work on the other issue as well |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
| } | ||
| // Register the otlp_grpc alias for the otlp exporter | ||
| aliasFactory := otlpexporter.NewFactoryWithAlias() | ||
| factories.Exporters[aliasFactory.Type()] = aliasFactory |
There was a problem hiding this comment.
This file is generated by ocb. We cannot modify it here. It should be implemented as a generic solution that allows any components define one deprecated alias name
There was a problem hiding this comment.
I think we now have a generic solution to component name aliases with #14349 merged, correct?
If confirmed, we should close this PR and potentially create a new PR changing otlp exporter to otlp_grpc with otlp alias?
There was a problem hiding this comment.
Yes, if it is confirmed, feel free to close this PR, I will create a new PR for the generic solution. How it sounds for you @dmitryax?
3 participants
Link to tracking issue
Fixes #14099