Remove usage of gogoproto and generate the structs with pdatagen#14069
Closed
bogdandrutu wants to merge 1 commit into
Closed
Remove usage of gogoproto and generate the structs with pdatagen#14069bogdandrutu wants to merge 1 commit into
bogdandrutu wants to merge 1 commit into
Conversation
bogdandrutu
requested review from
a team,
dmathieu,
dmitryax and
mx-psi
as code owners
bogdandrutu
force-pushed
the
rm-gogo-proto
branch
10 times, most recently
from
5b3da2e to
29032fa
Compare
bogdandrutu
force-pushed
the
rm-gogo-proto
branch
from
29032fa to
38bb757
Compare
bogdandrutu
requested review from
andrzej-stencel and
evan-bradley
as code owners
bogdandrutu
force-pushed
the
rm-gogo-proto
branch
2 times, most recently
from
0180604 to
217b0f4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14069 +/- ##
==========================================
- Coverage 92.50% 92.23% -0.28%
==========================================
Files 660 656 -4
Lines 36196 41110 +4914
==========================================
+ Hits 33483 37916 +4433
- Misses 1892 2183 +291
- Partials 821 1011 +190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
force-pushed
the
rm-gogo-proto
branch
4 times, most recently
from
d3b139a to
e30fc3c
Compare
jmacd
reviewed
Oct 24, 2025
Comment on lines
31
to
-76
| @@ -41,7 +41,7 @@ func new{{ .structName }}(orig *{{ .originFullName }}, state *internal.State) {{ | |||
| // This must be used only in testing code. Users should use "AppendEmpty" when part of a Slice, | |||
| // OR directly access the member if this is embedded in another struct. | |||
| func New{{ .structName }}() {{ .structName }} { | |||
| return new{{ .structName }}(internal.NewOrig{{ .originName }}(), internal.NewState()) | |||
| return new{{ .structName }}(internal.New{{ .originName }}(), internal.NewState()) | |||
| } | |||
|
|
|||
| // MoveTo moves all properties from the current struct overriding the destination and | |||
| @@ -53,7 +53,7 @@ func (ms {{ .structName }}) MoveTo(dest {{ .structName }}) { | |||
| if ms.{{ .origAccessor }} == dest.{{ .origAccessor }} { | |||
| return | |||
| } | |||
| internal.DeleteOrig{{ .originName }}(dest.{{ .origAccessor }}, false) | |||
| internal.Delete{{ .originName }}(dest.{{ .origAccessor }}, false) | |||
| *dest.{{ .origAccessor }}, *ms.{{ .origAccessor }} = *ms.{{ .origAccessor }}, *dest.{{ .origAccessor }} | |||
| } | |||
|
|
|||
| @@ -64,15 +64,15 @@ func (ms {{ .structName }}) MoveTo(dest {{ .structName }}) { | |||
| // CopyTo copies all properties from the current struct overriding the destination. | |||
| func (ms {{ .structName }}) CopyTo(dest {{ .structName }}) { | |||
| dest.{{ .stateAccessor }}.AssertMutable() | |||
| internal.CopyOrig{{ .originName }}(dest.{{ .origAccessor }}, ms.{{ .origAccessor }}) | |||
| internal.Copy{{ .originName }}(dest.{{ .origAccessor }}, ms.{{ .origAccessor }}) | |||
| } | |||
|
|
|||
| {{ if .hasWrapper -}} | |||
| func (ms {{ .structName }}) getOrig() *{{ .originFullName }} { | |||
| return internal.GetOrig{{ .structName }}(internal.{{ .structName }}(ms)) | |||
| func (ms {{ .structName }}) getOrig() *internal.{{ .originName }} { | |||
| return internal.Get{{ .structName }}Orig(internal.{{ .structName }}Wrapper(ms)) | |||
| } | |||
|
|
|||
| func (ms {{ .structName }}) getState() *internal.State { | |||
| return internal.Get{{ .structName }}State(internal.{{ .structName }}(ms)) | |||
Contributor
There was a problem hiding this comment.
Idea how to reduce the size of this change, is that each change in this file looks unnecessary but nice-to-have for clarity.
- Insertion of "Wrapper"
- originFullName -> internal.originName
- NewOrig -> New
- DeleteOrig -> Delete
- CopyOrig -> Copy
- etc
If the modified code generator were to preserve everything the way it has been, the change would be smaller. We could apply the improvements in a subsequent PRs, they would be more mechanical and easy to review.
Member
Author
There was a problem hiding this comment.
Insertion of "Wrapper"
The new protos will conflict with the names of the proto.
bogdandrutu
force-pushed
the
rm-gogo-proto
branch
2 times, most recently
from
eec0bbb to
02f819d
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
rm-gogo-proto
branch
from
02f819d to
4d508ba
Compare
Member
Author
|
Replaced by #14078 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge PR that does not touch any of the critical logic "marshaling/unmarshaling" of the pdata. We have e2e tests with the go official generated protobufs to ensure nothing breaks.
The easy way to review this is to only look at what change publicly in "pdata/pcommon", "pdata/plog", "pdata/ptrace", "pdata/pmetric", "pdata/pprofile", "pdata/xpdata".
This PR also switches the xpada request to use the same generating mechanism as pdatagen.
Binary size before:
Binary size after: