Skip to content

[chore] Fix check-codeowners workflow #13987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 1 commit into from
Oct 10, 2025
Merged

[chore] Fix check-codeowners workflow #13987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/check-codeowners.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ jobs:
app-id: ${{ vars.OTELBOT_APP_ID }}
private-key: ${{ secrets.OTELBOT_PRIVATE_KEY }}

# NOTE: the make command below intentionally uses the Makefile from the
# target branch, and not the PR checkout, since it runs with the
# pull_request_target event and has elevated permissions.
- name: Gen CODEOWNERS
run: |
cd pr
GITHUB_TOKEN=${{ steps.otelbot-token.outputs.token }} ../.tools/githubgen --default-codeowner "open-telemetry/collector-approvers" codeowners
GITHUB_TOKEN=${{ steps.otelbot-token.outputs.token }} GITHUBGEN_ARGS="-folder=./pr" make generate-codeowners
git diff -s --exit-code || (echo 'Generated code is out of date, please run "make generate-codeowners" or apply this diff and commit the changes in this PR.' && git diff && exit 1)
13 changes: 8 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,21 +462,24 @@ mdatagen-test:
cd cmd/mdatagen && $(MAKE) fmt
cd cmd/mdatagen && $(GOCMD) test ./...

GITHUBGEN_ARGS ?= -skipgithub
GITHUBGEN := $(GO_TOOL) githubgen $(GITHUBGEN_ARGS)

.PHONY: generate-gh-issue-templates
generate-gh-issue-templates:
$(GO_TOOL) githubgen issue-templates
$(GITHUBGEN) issue-templates

.PHONY: generate-codeowners
generate-codeowners:
$(GO_TOOL) githubgen --default-codeowner "open-telemetry/collector-approvers" -skipgithub codeowners
$(GITHUBGEN) --default-codeowner "open-telemetry/collector-approvers" codeowners

.PHONY: gengithub
gengithub: generate-codeowners generate-gh-issue-templates

.PHONY: gendistributions
gendistributions:
$(GO_TOOL) githubgen distributions
$(GITHUBGEN) distributions

.PHONY: generate-chloggen-components
generate-chloggen-components: $(GITHUBGEN)
$(GO_TOOL) githubgen chloggen-components
generate-chloggen-components:
$(GITHUBGEN) chloggen-components
Loading